Clay: Verify clay-pagination for 3.0.0 release

Created on 16 Sep 2019  ·  4Comments  ·  Source: liferay/clay

  • [ ] Are you able to easily implement a demo of this component? Are there any “gotchas” when implementing? Provide a link to codesandbox for a demo.
  • [ ] Does the component accept additional HTML attributes? For example, adding an aria attribute to a button.
  • [ ] Does component accept a ref? Is the ref value what you would expect?
  • [ ] Does this component allow for different translations?
  • [ ] If this is a form element, does it accept a name attribute?
  • [ ] Were you able to find documentation for this component? Was it clear?

Additional Questions:

  • Is there anything about the public API that you would change?
  • Is the naming of the available props clear?
3.x clay-components

Most helpful comment

Yep, I guess all components should accept ...otherProps and render'em in the main (or more logic) element.

All 4 comments

I'm currently using a local project created with create-react-app to try the components and ran into this issue

2019-09-17-172618_1600x900_scrot

Here's the code I was using and I might have forgotten something, but just in case someone can double check

import React, {useState} from 'react';
import ClayPagination from '@clayui/pagination';

import '@clayui/css/lib/css/atlas.css';

const spritemap = require('@clayui/css/lib/images/icons/icons.svg');

function App() {
    const [active, setActive] = useState(1);
    const totalPages = 100;

  return (
        <div id="app">
            <ClayPagination
                arial-label="pagination"
                activePage={active}
                onPageChange={setActive}
                spritemap={spritemap}
                totalPages={totalPages}
            />
        </div>
  );
}

export default App;

This one also needs support for extra attributes (it seemed that aria-label didn't get passed in my example) so I can send a PR for that

Yep, I guess all components should accept ...otherProps and render'em in the main (or more logic) element.

After speaking with @marcoscv @bryceosterhaus @diegonvs and @eduardoallegrini we think it might be better analysing each component to find a general pattern or at least a good way to support accesibility related attributes. So I'll won't send a PR just right now.

Publish #2608

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bryceosterhaus picture bryceosterhaus  ·  4Comments

pat270 picture pat270  ·  4Comments

brunofarache picture brunofarache  ·  5Comments

ethib137 picture ethib137  ·  4Comments

hold-shift picture hold-shift  ·  3Comments