Clarity: nav box-shadow should be black in dark theme

Created on 11 Dec 2017  路  3Comments  路  Source: vmware/clarity

Select one ... (check one with "x")

[ ] bug
[ ] feature request
[x] enhancement

Expected behavior

When the dark theme is applied, the horizontal nav tabs should have a black border along the bottom:

screen shot 2017-12-11 at 12 16 36 pm

Actual behavior

box-shadow with #ccc gives a border color that looks white:

screen shot 2017-12-11 at 12 15 53 pm

Reproduction of behavior

use the nav tabs component

Environment details

  • Angular version: 4.3.x

  • Clarity version: 0.10.16

  • OS and version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Dev bug

Most helpful comment

@mathisscott
Design review completed and approved. For the not-active tab, please change the bottom 1 px color to: #485764

It should look like this:
image

All 3 comments

Hi Scott,
Please hold off on this change until I do a design review. I want to make sure whatever color is chosen works across all screens.

@mathisscott
Design review completed and approved. For the not-active tab, please change the bottom 1 px color to: #485764

It should look like this:
image

Hi there 馃憢, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

Was this page helpful?
0 / 5 - 0 ratings