Clarity: [Datagrid] Manually updating clrDgPageSize no longer results in clrDgRefresh being triggered

[jbgarr]

[X] bug
[ ] feature request
[ ] enhancement

Expected behavior

Manually updating the clrDgPageSize should trigger a clrDgRefresh event to be fired on the table (this was how it worked in Clarity v0.9.x).

Actual behavior

Manually updating clrDgPageSize no longer triggers a clrDgRefresh event.

Reproduction of behavior

Here is a working version (v0.9.x): https://plnkr.co/edit/7PBBUqnPSopd21NCyfxU?p=preview
And here is the same code running in v0.10.x where the event is no longer fired: https://plnkr.co/edit/cl9WfX76lYlbVTh6nm2u?p=preview

Environment details

• Angular version: 4.x.x

• Clarity version:

• OS and version: MacOS Sierra

• Browser: Chrome 62.0.3202.94 (Official Build) (64-bit)

[hippee-lee]

StateProvider.change is not broadcasting events to Datagrid for some reason. I traced it into the settor for clrDgPageSize and stopped there for now.

[dragon503]

@jbgarr Have you fixed it?
I met the same issue and use "clrDgStateChange" as mentioned in #2094 but do not work.

[stefnoten]

We have the same problem. The problem seems to be that the Page service does not trigger the StateDebouncer inside the size setter. It only does this for changes of the current page.

The StateDebouncer on its turn triggers a change in the StateProvider, which triggers the refresh event.

[m-tomczyk]

Will this issue be addressed by Clarity team in upcoming releases? Or maybe is it open for contribution? It will soon become blocker issue for our project.

[mathisscott]

@m-tomczyk
This is on our radar but we do not currently have it assigned to anyone to be fixed. If it is a potential blocker for your team, we are certainly open to contributions.

[Jinnie]

Btw, plunkr reproduction no longer working.
Attaching the stackblitz one I did while researching the issue, if needed for future reference:
https://stackblitz.com/edit/clarity-issue-1752

[Jinnie]

Fixed in 0.13 and 1.0
Thanks, @stefnoten and @hippee-lee for the issue research. Very helpful!

[github-actions[bot]]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.