Caseflow: Cancel duplicate JudgeDecisionReviewTasks

Created on 12 Dec 2019  ·  7Comments  ·  Source: department-of-veterans-affairs/caseflow

Wraps up #12802

Description


Pending @jimruggiero 's approval, cancel tasks related to the duplicate JudgeDecisionReviewTasks.

As of Dec 11th, 2019, all 10 appeals with this problem are enumerated here, along with additional commentary: https://github.com/department-of-veterans-affairs/caseflow/issues/12802#issuecomment-564676936

A Google Doc titled "Appeals with JDRT duplication" revealing usernames and CSS_IDs was created for Jim to communicate with stakeholders. https://dsva.slack.com/archives/CQCUMFA0H/p1576171321003400?thread_ts=1576091438.082500&cid=CQCUMFA0H

Background/context/resources

Duplicate tasks for appeal 3653 (one of the broken appeals) was recently brought up as a problem presented to Bat Team: https://dsva.slack.com/archives/CHX8FMP28/p1576168737189300?thread_ts=1576165907.183700&cid=CHX8FMP28

Technical notes

As stated in the comment for #12802:

If you run AttorneyTask.update(status: "cancelled"), the JudgeDecisionReviewTask is automatically cancelled and a new JudgeAssignTask is created -- undesirable!
Avoid these callbacks by using update_all like so: Task.where(id: [atty_tsk_id, judge_task_id]).update_all(status: "cancelled")

I tested this command on test appeals with similar structures, and it works with no additional side-effects that I can tell.

High BVA Echo 🐬 Bug
Source
picture yoomlam

All 7 comments

On Dec 18th, appeal 37770 was fixed by Kat: https://dsva.slack.com/archives/CHX8FMP28/p1576688890093400
and appeal 3653 was fixed by Yoom: https://dsva.slack.com/archives/CHX8FMP28/p1576168737189300?thread_ts=1576165907.183700&cid=CHX8FMP28

yoomlam picture yoomlam on 6 Jan 2020

The following appeals were fixed by board request on 12/27.
12445, 15081, 3653, 37770, 39812, 41138, 7178, 8460, 8710, 9323

Appeal 3653 [status]
└── RootTask cancelled
    ├── TrackVeteranTask cancelled
    ├── DistributionTask completed
    │   ├── EvidenceSubmissionWindowTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
Appeal 7178 [status]
└── RootTask on_hold
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    └── JudgeDecisionReviewTask assigned
        └── AttorneyTask completed
Appeal 8460 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask on_hold
    │   └── AttorneyTask assigned
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
Appeal 8710 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask cancelled
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    │       └── OtherColocatedTask completed
    │           └── OtherColocatedTask completed
    │               └── TimedHoldTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 9323 [status]
└── RootTask on_hold
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask on_hold
    │   └── AttorneyTask on_hold
    │       └── FoiaColocatedTask on_hold
    │           └── FoiaTask assigned
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeAssignTask completed
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
Appeal 12445 [status]
└── RootTask on_hold
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    └── JudgeDecisionReviewTask on_hold
        └── AttorneyTask on_hold
            └── HearingClarificationColocatedTask on_hold
                ├── HearingClarificationColocatedTask cancelled
                └── HearingClarificationColocatedTask on_hold
                    └── TimedHoldTask assigned
Appeal 15081 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    │   ├── EvidenceSubmissionWindowTask completed
    │   └── InformalHearingPresentationTask completed
    │       └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask on_hold
    │   └── AttorneyTask on_hold
    │       └── IhpColocatedTask on_hold
    │           └── IhpColocatedTask assigned
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
            └── IhpColocatedTask cancelled
                └── IhpColocatedTask cancelled
Appeal 37770 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask assigned
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask cancelled
        └── BvaDispatchTask cancelled
Appeal 39812 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    ├── JudgeDecisionReviewTask cancelled
    ├── JudgeDecisionReviewTask cancelled
    ├── BvaDispatchTask completed
    │   └── BvaDispatchTask completed
    └── JudgeDecisionReviewTask cancelled
Appeal 41138 [status]
└── RootTask on_hold
    ├── DistributionTask completed
    ├── JudgeAssignTask cancelled
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask on_hold
    │   └── AttorneyTask assigned
    │       └── OtherColocatedTask cancelled
    │           └── OtherColocatedTask cancelled
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
            └── OtherColocatedTask cancelled
                └── OtherColocatedTask cancelled
hschallhorn picture hschallhorn on 7 Jan 2020
🎉1

7951 was fixed via user request on 1/3

hschallhorn picture hschallhorn on 7 Jan 2020
👍1

Fixing appeals that have been dispatched from board request: 20212, 762, 3054, 19023, 10094, 3416, 6903, 8554, 5684, 11928, 1849, 2808

appeal_ids = [20212, 762, 3054, 19023, 10094, 3416, 6903, 8554, 5684, 11928, 1849, 2808]
appeals = Appeal.find(appeal_ids)

# Let's make sure these have all really been dispatched 
appeals.all? { |appeal| BvaDispatchTask.completed.where(appeal: appeal).present? }
=> true

# Grabbing all open tasks on these appeals
tasks_to_close = Task.open.where(appeal: appeals)
tasks_to_close.count
=> 31

# Alright let's cancel!
tasks_to_close.update_all(status: Constants.TASK_STATUSES.cancelled, closed_at: Time.zone.now)
hschallhorn picture hschallhorn on 7 Jan 2020
👍1

Cancelling 12416 by board request

appeal = Appeal.find(12416)
puts appeal.structure_render(:id, :status)
Appeal 12416 [id, status]
└── RootTask 285861, on_hold
    ├── TrackVeteranTask 285862, in_progress
    ├── DistributionTask 285863, completed
    │   └── InformalHearingPresentationTask 285864, completed
    │       └── InformalHearingPresentationTask 515495, completed
    ├── JudgeAssignTask 562917, cancelled
    ├── JudgeAssignTask 564796, completed
    ├── JudgeDecisionReviewTask 570237, on_hold
    │   ├── AttorneyTask 570239, completed
    │   └── OtherColocatedTask 596673, on_hold
    │       └── OtherColocatedTask 596674, assigned
    └── JudgeDecisionReviewTask 570242, on_hold
        ├── AttorneyTask 570243, completed
        └── OtherColocatedTask 596671, on_hold
            └── OtherColocatedTask 596672, assigned

tasks_to_close = Task.where(id: [570242, 596671, 596672])
tasks_to_close.update_all(status: Constants.TASK_STATUSES.cancelled, closed_at: Time.zone.now)
hschallhorn picture hschallhorn on 7 Jan 2020
👍1

Making sure we've got all of them this time

appeal_ids = JudgeDecisionReviewTask.not_cancelled.group(:appeal_id).count.select do |appeal_id, count| 
  count > 1 &&
  Appeal.find(appeal_id).tasks.open.present?
end.keys
appeal_ids.count
=> 0

appeal_ids = JudgeAssignTask.not_cancelled.group(:appeal_id).count.select do |appeal_id, count| 
  count > 1 &&
  Appeal.find(appeal_id).tasks.not_cancelled.where(type: JudgeDecisionReviewTask.name).present? &&
  Appeal.find(appeal_id).tasks.open.where(type: JudgeAssignTask.name).present?
end.keys
appeal_ids.count
=> 0
hschallhorn picture hschallhorn on 7 Jan 2020
🎉1

Verifying these final trees have been fixed. @pshahVA @jimruggiero 

appeal_ids = [20212, 762, 3054, 19023, 10094, 3416, 6903, 8554, 5684, 11928, 1849, 2808, 12416, 7951]
appeals = Appeal.find(appeal_ids)
puts appeals.map { |appeal| appeal.structure_render(:status) }

Appeal 20212 [status]
└── RootTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 762 [status]
└── RootTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    │       └── PreRoutingTranslationColocatedTask completed
    │           └── PreRoutingTranslationColocatedTask completed
    │               └── TranslationTask completed
    │                   └── TranslationTask completed
    │                       └── TimedHoldTask cancelled
    ├── TrackVeteranTask completed
    ├── JudgeDecisionReviewTask completed
    │   ├── AttorneyTask completed
    │   └── AttorneyRewriteTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 3054 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 19023 [status]
└── RootTask cancelled
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    ├── BvaDispatchTask completed
    │   └── BvaDispatchTask completed
    ├── JudgeAssignTask completed
    │   └── OtherColocatedTask completed
    │       └── OtherColocatedTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    │       └── OtherColocatedTask cancelled
    │           └── OtherColocatedTask cancelled
    ├── TrackVeteranTask cancelled
    └── InformalHearingPresentationTask completed
Appeal 10094 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    │       ├── OtherColocatedTask completed
    │       │   └── OtherColocatedTask completed
    │       └── OtherColocatedTask cancelled
    │           └── OtherColocatedTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 3416 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    │       └── OtherColocatedTask completed
    │           └── OtherColocatedTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        ├── BvaDispatchTask cancelled
        └── BvaDispatchTask completed
Appeal 6903 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    │       └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        ├── BvaDispatchTask cancelled
        └── BvaDispatchTask completed
Appeal 8554 [status]
└── RootTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 5684 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   ├── AttorneyTask completed
    │   └── OtherColocatedTask cancelled
    │       └── OtherColocatedTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        ├── BvaDispatchTask cancelled
        └── BvaDispatchTask completed
Appeal 11928 [status]
└── RootTask completed
    ├── DistributionTask completed
    │   └── EvidenceSubmissionWindowTask completed
    ├── TrackVeteranTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   ├── AttorneyTask completed
    │   ├── OtherColocatedTask completed
    │   │   └── OtherColocatedTask completed
    │   └── OtherColocatedTask cancelled
    │       └── OtherColocatedTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        ├── BvaDispatchTask cancelled
        └── BvaDispatchTask completed
Appeal 1849 [status]
└── RootTask cancelled
    ├── TrackVeteranTask completed
    ├── TrackVeteranTask completed
    ├── TrackVeteranTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   ├── EvidenceSubmissionWindowTask completed
    │   └── InformalHearingPresentationTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    ├── EvidenceOrArgumentMailTask completed
    │   └── EvidenceOrArgumentMailTask completed
    │       └── EvidenceOrArgumentMailTask completed
    ├── EvidenceOrArgumentMailTask completed
    │   └── EvidenceOrArgumentMailTask completed
    │       └── EvidenceOrArgumentMailTask completed
    ├── BvaDispatchTask completed
    │   └── BvaDispatchTask completed
    ├── ReconsiderationMotionMailTask completed
    │   └── ReconsiderationMotionMailTask completed
    │       └── ReconsiderationMotionMailTask completed
    ├── EvidenceOrArgumentMailTask completed
    │   └── EvidenceOrArgumentMailTask completed
    │       └── EvidenceOrArgumentMailTask completed
    ├── JudgeAssignTask completed
    └── JudgeDecisionReviewTask cancelled
        └── AttorneyTask cancelled
            └── OtherColocatedTask cancelled
                └── OtherColocatedTask cancelled
Appeal 2808 [status]
└── RootTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   ├── AttorneyTask completed
    │   └── AttorneyRewriteTask cancelled
    │       └── OtherColocatedTask completed
    │           ├── OtherColocatedTask cancelled
    │           └── OtherColocatedTask completed
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 12416 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    │       └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask cancelled
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask on_hold
    │   ├── AttorneyTask completed
    │   └── OtherColocatedTask on_hold
    │       └── OtherColocatedTask assigned
    └── JudgeDecisionReviewTask cancelled
        ├── AttorneyTask completed
        └── OtherColocatedTask cancelled
            └── OtherColocatedTask cancelled
Appeal 7951 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeDecisionReviewTask completed
    │   └── AttorneyTask completed
    ├── BvaDispatchTask completed
    │   └── BvaDispatchTask completed
    └── JudgeAssignTask cancelled
hschallhorn picture hschallhorn on 7 Jan 2020
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lomky picture lomky  ·  5Comments
laurjpeterson picture laurjpeterson  ·  5Comments
hschallhorn picture hschallhorn  ·  4Comments
gnakm picture gnakm  ·  5Comments
laurjpeterson picture laurjpeterson  ·  5Comments