Caseflow: Document Viewer | Placing annotation between different documents

Created on 25 May 2017  ·  5Comments  ·  Source: department-of-veterans-affairs/caseflow

Story
Right now, a user can be in annotation mode when switching between documents. This is confusing because users may be adding comments to a document they weren't intending to.

AC

  • [ ] When a user is in annotation mode and switches to another document, document should be automatically taken out of annotation mode.

Related Issue

1768

Medium caseflow-reader Whiskey Bug

Most helpful comment

@gnakm I think that moving between pages should just take you out of annotation writing mode. That way it is consistent with our behavior for placing annotations. Also, we need to leave annotation placing mode if we hit the back to all documents button. Removing the buttons might be really confusing.

All 5 comments

@gnakm What are the buttons supposed to look like if disabled?

Just take them out @mmlumba

@gnakm I think that moving between pages should just take you out of annotation writing mode. That way it is consistent with our behavior for placing annotations. Also, we need to leave annotation placing mode if we hit the back to all documents button. Removing the buttons might be really confusing.

@mdbenjam I see what you were saying. That makes more sense to me.

Changing the AC from

  • When you enter “placing annotation” mode, next and previous buttons should be disabled (not on the page) until annotation is either saved or cancelled.
    to
  • When a user is in annotation mode and switches to another document, document should be automatically taken out of annotation mode.

Also changed the story because it was confusing me.

Previous story:

If you enter “placing annotation” mode, then you move to a different document, you’ll leave “placing annotation” mode. “Placing annotation” mode, place an annotation by clicking, then move to a different document, we have the original bug.

PASSED

annotaitons

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hschallhorn picture hschallhorn  ·  4Comments

laurjpeterson picture laurjpeterson  ·  5Comments

laurjpeterson picture laurjpeterson  ·  4Comments

laurjpeterson picture laurjpeterson  ·  5Comments

lomky picture lomky  ·  3Comments