Botbuilder-samples: Attachment.name has prefix fromClient:: when coming from WebChat

[HesselWellema]

BotBuilder-Samples/samples/javascript_nodejs/15.handling-attachments/

When hosted on Azure, attachment.name containts a prefix ::fromClient. in my case this caused an InternalServerErrror on Azure. Fs actually throws an error that i cannot find the file. See https://stackoverflow.com/questions/58306146/internal-server-error-om-azure-when-writing-file-from-buffer-to-filesystem
I had to remove the prefix for it to work

To Reproduce

Steps to reproduce the behavior:
Host the attachmentbot on Azure (Node)
Upload an attachment.
Crash

[dmvtech]

I can this as well. Looking into it further.

[dmvtech]

This seems to be the case for only Test in Web Chat (haven't tested full web chat yet). But does not happen in MS Teams, Telegram or Skype.

@HesselWellema can you confirm that Test in Web Chatis where you are witnessing the behavior. Do you have any other channels that exhibit this behavior?

[dmvtech]

Additionally, it doesn't have to be hosted in Azure. I have tested with a locally hosted bot and it throws an exception there too. It's just TiWC (at least for now).

[HesselWellema]

Hi, locally running on Node with bot emulator I did not witness any issues. Attachment.name does not resolve with a ::fromClient prefix in that case. I did witness the issue in full webchat.

[dmvtech]

thanks @HesselWellema

I meant to say that I tested a bot that was in azure, but the endpoint (code) was hosted locally (using ngrok). I didn't test in emulator, but thanks for that info.

I also confirmed iframe webchat is failing. I am testing with full web chat, newer versions. Stand by.

[dmvtech]

Finding: this is done by the DirectLine service.

[dmvtech]

Fix is in the pipeline. Should ship this week.

[dmvtech]

This fix is in place. @HesselWellema can you confirm it works for you?

[HesselWellema]

Tested in webchat. Works like a charm. Thank you!