Bforartists: change vertexes to vertices, typo in Blender

Created on 24 Oct 2020  Â·  11Comments  Â·  Source: Bforartists/Bforartists

while doing a previous commit I found this typo in the hint message of Sculpt Mode > Brush Settings > Front Faces Only (previously Advanced)

it is possible that this typo exists also in other places
image

0 - task 1- Fixed

All 11 comments

~still not sure, I think vertexes is valid too, will investigate more to be in favor of consistency~
vertices is the correct one

it is possible that this typo exists also in other places

Do a grep search and we know :)

When you are at windows: https://tools.stefankueng.com/grepWin.html

Not this much. But two more in tooltips are here: sourceblendermakesrnainternrna_brush.c

The rest is comments. Not important.

Leaving the pull request open so that you can change these two rascals too :)

great will change them now

Just noticed that in your commits the issue number is missing in the commit message. Could you please add them in the next commits? It's the #1234 number at the end of the issue title. Makes my live with writing the manual much easier. And that's how the commits are connected with the issues then :)

oh ok will mention them

Thanks a bunch. Best practice is to simply copy the issue title including the number.

Great I've just added the new commit

Okay, I will now delete your branch. We will continue with the new method now, and create a new branch for every issue. I hope you have read the PM and the forum entry meanwhile.

If not, here are the new commit rules:

Create a new branch for every new commit and its pull request. As the name for the branch use an issue_ as a prefix. Followed by the issue number.

For example:

3D View – Lights defaults to have Contact Shadows turned on #1903
becomes a branch with the name
issue_1903

This way you can make as much pull requests as you want, and we never run into a conflict here :)

oh I have just noticed the PMs, I didn't check the forums, reading through it now
great yeah I think branch per feature is good.
some changes can be like one line but the branches are disposable, so no probs.

Yup :)
We simply did it wrong in the past. Sorry. Git was never meant to work with a dev branch. But you never stop learning. And it's never too late to make it right :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ReinerBforartists picture ReinerBforartists  Â·  4Comments

CyberFoxHax picture CyberFoxHax  Â·  6Comments

iyadahmed picture iyadahmed  Â·  6Comments

iyadahmed picture iyadahmed  Â·  7Comments

Draise14 picture Draise14  Â·  6Comments