Bentobox: WARN spam on server start-up.

[SlimeDog]

Description

Describe the bug

WARN spam on server start-up.

[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIslandDeleted(world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandUnregisteredEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIsland(world.bentobox.bentobox.api.events.island.IslandEvent$IslandUnregisteredEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamLeaveEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIsland(world.bentobox.bentobox.api.events.team.TeamEvent$TeamLeaveEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandRegisteredEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIsland(world.bentobox.bentobox.api.events.island.IslandEvent$IslandRegisteredEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamJoinedEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIsland(world.bentobox.bentobox.api.events.team.TeamEvent$TeamJoinedEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamKickEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIsland(world.bentobox.bentobox.api.events.team.TeamEvent$TeamKickEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandPreclearEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onIslandDelete(world.bentobox.bentobox.api.events.island.IslandEvent$IslandPreclearEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onNewIslandOwner(world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandCreatedEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onNewIsland(world.bentobox.bentobox.api.events.island.IslandEvent$IslandCreatedEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandResettedEvent on method "public void world.bentobox.level.listeners.IslandActivitiesListeners.onNewIsland(world.bentobox.bentobox.api.events.island.IslandEvent$IslandResettedEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:26] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent on method "public void world.bentobox.biomes.listeners.ChangeOwnerListener.onTeamSetOwnerEvent(world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[18:22:27] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1930" has registered a listener for world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteChunksEvent on method "public void world.bentobox.bentobox.managers.IslandDeletionManager.onIslandDelete(world.bentobox.bentobox.api.events.island.IslandEvent$IslandDeleteChunksEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].

Steps to reproduce the behavior

• Update to dev build 1930; no change to other BBox components or other plugins
• Start server

Expected behavior

Clean re-start

Environment

Output of /bbox version (Mandatory)

>bbox version
[18:26:49] [Server thread/INFO]: Running SPIGOT 1.16.4.
[18:26:49] [Server thread/INFO]: BentoBox version: 1.15.4-SNAPSHOT-b1930
[18:26:49] [Server thread/INFO]: Database: JSON
[18:26:49] [Server thread/INFO]: Loaded Game Worlds:
[18:26:49] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[18:26:49] [Server thread/INFO]: Loaded Addons:
[18:26:49] [Server thread/INFO]: Biomes 1.13.0-SNAPSHOT-b196 (ENABLED)
[18:26:49] [Server thread/INFO]: BSkyBlock 1.13.0-SNAPSHOT-b601 (ENABLED)
[18:26:49] [Server thread/INFO]: Challenges 0.8.4-SNAPSHOT-b436 (ENABLED)
[18:26:49] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[18:26:49] [Server thread/INFO]: Level 2.5.0-SNAPSHOT-b425 (ENABLED)

[tastybento]

Thanks - this is expected - these are just warnings that the API is being deprecated. I am deprecating the events and the addons will need to update to the newer locations of those events. In your case, it will be Level and Biomes. They will be updated soon.

[SlimeDog]

I assumed as much, but wanted to get it recorded. I would have left it open until the issue was actually resolved, but it's your Github. :)

[tastybento]

Fair enough - it's a work in progress. I just merged a PR and then all these warnings have to be resolved in their respective addons, which I'm working on now.

[SlimeDog]

Thank you.

[BONNe]

I implemented proper event handling in:

Biomes, Challenges, Likes, MCG, and Visit.

These should stop spamming in the latest dev version.

[SlimeDog]

Looking good on latest dev BentoBox, with latest Challenges and Level. There is still BSkyBlock (and maybe the other block addons that we don't use).

[tastybento]

I implemented proper event handling in:

Biomes, Challenges, Likes, MCG, and Visit.

These should stop spamming in the latest dev version.

@BONNe It looks the Biomes commit went onto a branch called "develops" instead of "develop" - was that intentional?

[SlimeDog]

Biomes commit went onto a branch called "develops" instead of "develop"

That explains why there was not a Biomes update, but there is no WARN message for Biomes. It looks like ExtraMobs doesn't need an update -- no WARN message, anyway.

[tastybento]

There will be no change required for BSkyBlock - it doesn't generate any events of its own. Only AcidIsland and AOneBlock make events. I just updated those.

[SlimeDog]

[17:39:17] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1934" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent on method "public void world.bentobox.biomes.listeners.ChangeOwnerListener.onTeamSetOwnerEvent(world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].

[tastybento]

^^^ That's Biomes.

[SlimeDog]

OK, thanks.

[SlimeDog]

>bbox version
[07:16:21] [Server thread/INFO]: Running SPIGOT 1.16.4.
[07:16:21] [Server thread/INFO]: BentoBox version: 1.15.4-SNAPSHOT-b1935
[07:16:21] [Server thread/INFO]: Database: JSON
[07:16:21] [Server thread/INFO]: Loaded Game Worlds:
[07:16:21] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[07:16:21] [Server thread/INFO]: Loaded Addons:
[07:16:21] [Server thread/INFO]: Biomes 1.13.0-SNAPSHOT-b197 (ENABLED)
[07:16:21] [Server thread/INFO]: BSkyBlock 1.14.3 (ENABLED)
[07:16:21] [Server thread/INFO]: Challenges 0.8.4-SNAPSHOT-b437 (ENABLED)
[07:16:21] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[07:16:21] [Server thread/INFO]: Level 2.5.1-SNAPSHOT-b429 (ENABLED)

On start-up, still the WARN message

[07:06:45] [Server thread/INFO]: [BentoBox] Loading BentoBox v1.15.4-SNAPSHOT-b1935
[07:06:49] [Server thread/INFO]: [BentoBox] Enabling BentoBox v1.15.4-SNAPSHOT-b1935
[07:06:49] [Server thread/INFO]: [BentoBox] Loading Settings from config.yml...
[07:06:51] [Server thread/INFO]: [BentoBox] Hooking with Vault...
[07:06:51] [Server thread/INFO]: [BentoBox] Loading addons...
[07:06:52] [Server thread/INFO]: [BentoBox] Loaded 5 addons.
[07:07:03] [Server thread/INFO]: [VoidSpawn] BentoBox found, initializing support.
[07:07:03] [Server thread/INFO]: [VoidSpawn] BentoBox support initialized.
[07:08:10] [Server thread/INFO]: Checking 'BentoBox v1.15.4-SNAPSHOT-b1935' for BSkyBlock
[07:08:14] [Server thread/INFO]: [BentoBox] Hooking with PlaceholderAPI...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling game mode addons...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling BSkyBlock (1.14.3)...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling other addons...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling Level (2.5.1-SNAPSHOT-b429)...
[07:08:14] [Server thread/INFO]: [BentoBox] [Level] Level hooking into BSkyBlock
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling ExtraMobs (1.11.0.4-SNAPSHOT-b7)...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling Challenges (0.8.4-SNAPSHOT-b437)...
[07:08:14] [Server thread/INFO]: [BentoBox] [Challenges] Loading challenges...
[07:08:14] [Server thread/INFO]: [BentoBox] Enabling Biomes (1.13.0-SNAPSHOT-b197)...
[07:08:14] [Server thread/INFO]: [BentoBox] Loading biomes...
[07:08:14] [Server thread/WARN]: [BentoBox] "BentoBox v1.15.4-SNAPSHOT-b1935" has registered a listener for world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent on method "public void world.bentobox.biomes.listeners.ChangeOwnerListener.onTeamSetOwnerEvent(world.bentobox.bentobox.api.events.team.TeamEvent$TeamSetownerEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [tastybento, Poslovitch].
[07:08:14] [Server thread/INFO]: [BentoBox] Addons successfully enabled.
[07:08:14] [Server thread/INFO]: [BentoBox] Hooking with Multiverse-Core...
[07:08:14] [Server thread/INFO]: Success! Property generator was set to BentoBox
[07:08:14] [Server thread/INFO]: Success! Property generator was set to BentoBox
[07:08:14] [Server thread/INFO]: Success! Property generator was set to BentoBox
[07:08:14] [Server thread/INFO]: [BentoBox] Hooking with WorldEdit...
[07:08:14] [Server thread/INFO]: BentoBox 1.15.4-SNAPSHOT-b1935 loaded successfully in 3327ms.
[07:08:14] [Server thread/INFO]: [Insights] Successfully registered addon BentoBox vv1.1.0!
[07:08:23] [Server thread/INFO]: [BentoBox] Added world SkyBlock (HARD)
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded Blueprint Bundle 'harder_island' for BSkyBlock.
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded Blueprint Bundle 'default' for BSkyBlock.
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded Blueprint Bundle 'double_island' for BSkyBlock.
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded blueprint 'nether-island' for BSkyBlock
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded blueprint 'end-island' for BSkyBlock
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded blueprint 'harder' for BSkyBlock
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded blueprint 'island' for BSkyBlock
[07:08:23] [Craft Scheduler Thread - 7/INFO]: [BentoBox] Loaded blueprint 'double' for BSkyBlock
[07:08:23] [Server thread/INFO]: [BentoBox] All blueprints loaded.
[07:08:23] [Craft Scheduler Thread - 3/INFO]: [BentoBox] [Level] Generating Top Ten Tables
[07:08:23] [Craft Scheduler Thread - 3/INFO]: [BentoBox] [Level] Loaded top ten for world_skyblock

[tastybento]

Try the latest Biomes. BONNe fixed the snapshot build a few hours ago.

[SlimeDog]

Per above, Biomes 1.13.0-SNAPSHOT-b197, built 7 hours ago. There is nothing later. All components are latest dev builds. (My automagical update tracker notifies me every 15 minutes.)

[tastybento]

Aha, okay. I see where the problem is. He fixed the events biomes make but did not change the listener to the non-deprecated one.

[SlimeDog]

That is consistent with the message presented. Suggestion: A quick "start up a server with downloaded BentoBox components" test would have exposed both errors.

[BONNe]

I missed that I need to update all listeners too...
pff... that is not nice...

As it will lock addons to dev version :(

[tastybento]

I'm planning on release BentoBox 1.15.4 soon, maybe tomorrow.

[SlimeDog]

Is someone going to address the remaining WARN message? Apparently it's in Biomes, per the above.

[BONNe]

I will fix Biomes in the next 2 days as well as other addons.

[SlimeDog]

thanks. HNY in 2021.

[SlimeDog]

Confirmed fixed in Biomes 1.14.0-b198 and all addons what we use. Spigot 1.16.4 (Jenkins 2978)

>bbox version
[07:59:10] [Server thread/INFO]: Running SPIGOT 1.16.4.
[07:59:10] [Server thread/INFO]: BentoBox version: 1.15.5
...
[07:59:11] [Server thread/INFO]: Loaded Addons:
[07:59:11] [Server thread/INFO]: Biomes 1.14.0-SNAPSHOT-b198 (ENABLED)
[07:59:11] [Server thread/INFO]: BSkyBlock 1.14.3 (ENABLED)
[07:59:11] [Server thread/INFO]: Challenges 0.8.4-SNAPSHOT-b438 (ENABLED)
[07:59:11] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[07:59:11] [Server thread/INFO]: Level 2.5.1 (ENABLED)

and Paper 1.16.4-366 as well.