Bentobox: Endermite dont spawn when throwing ender pearls

[SirvydasS]

Description

Describe the bug

I try in same world (island). Spaming ender pearls and dont work (endermites dont spawn). I see sometimes they spawn but immediately disappear. In normal world (no bskyblock) works fine. Then i removed bentobox plugin and restarted server and then agian try spam ender pearls and endermites start spawning normal in same place.

Steps to reproduce the behavior

Look down in your bskyblock island and spam ender pearls. Wait a 1-2 min about and you should start see that.

Screenshots and videos

Expected behavior

Endermites spawn when using ender pearls.

Environment

Server

• OS: Linux Debian-91-stretch-64-minimal 4.9.0-3-amd64
• Java version: 12

Plugins

BentoBox, Permissions, ProxyBridge

BentoBox setup

BentoBox and Addons

Running PAPER 1.14.4.
BentoBox version: 1.8.0-SNAPSHOT-b1389
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
BSkyBlock 1.8.0-SNAPSHOT-b464 (ENABLED)

Configuration

• Database: JSON

Additional context

[BONNe]

Oh, @Poslovitch
I think I know the issue here.
Endermites are spawned when player use ender pearl to teleport.
And we have RemoveMobsListener on player teleport ;)

[tastybento]

So, you can allow them to appear by adding them to the whitelist in config.yml. Maybe that the only change required?

[BONNe]

I think no.
BentoBox should separate teleportation from command, and teleporting from events, like eating corus flower and ender pearl throw.
As when a user executes a command, then mobs can be removed. But if teleportation is done via ender pearl or via corus flower, then mobs should not be removed. Otherwise, it could be abused to get rid of mobs...

[tastybento]

Makes sense @BONNe.

[BONNe]

And one more thing...
I think also removing mobs on teleportation should be toggleable in world settings.
(i think every custom code should be toggleable).

And probably, this is just an idea to avoid some exploits...
Removing mobs on teleportation should take effect only if it is done by command or plugin (not ender pearl and corus flower) and distance of teleporation is larger then mob removing distance.

f.e. if a player is already at the home location, and used the command "/is go" then it should not remove mobs.

Mobs should be removed only when it was large distance travel.

[tastybento]

Done in b448df541836cc8bb779f145d473efa181589944