Addons-frontend: Hide "no users" metadata entry for search tools (on add-on detail pages)

[willdurand]

Based on: https://github.com/mozilla/addons/issues/819.

---

We do not have any "install data" for search tools so we always show add-ons with "no users". Let's hide this message for search tools as it conveys a negative impact for no reason.

[sresthas]

Hey, I would like to work on this issue, please let me know how to get started

[caitmuenster]

Hey @twisted-sres, go for it!

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

Mentor: @willdurand

[sresthas]

I am trying to build it on my local machine, but ./mach build is taking a lot of time

[championshuttler]

Hey @twisted-sres are you building gecko / mozilla-central on your laptop by any chance?

For addons-frontend development, you can check the requirements here, in short, you need nodejs version 8+. After that, please install Yarn from here.

After that, you can install the project dependencies by running yarn install and then please run yarn test to make sure project is installed successfully. Now you can start the local dev server by using yarn amo:dev.

If you have any doubt. Feel free to ask here :)

[willdurand]

I am trying to build it on my local machine, but ./mach build is taking a lot of time

sorry but you don't need mach or any mozilla-central code. You should read and do what is described in https://github.com/mozilla/addons-frontend/blob/master/README.md#requirements and then run yarn && yarn amo:dev.

[sresthas]

So my setup is in progress, meanwhile I was going through the source code, which part of it actually needs to be edited and what is the expected result?

[sresthas]

I have finally build the project

[kartik-budhiraja]

Just wondering, @twisted-sres are you working on this issue or is it available?

[sresthas]

I wanted to know the expected result,

[kartik-budhiraja]

@twisted-sres , From what I understand, the expected result is that for "search type" addons, we should not display "No Users" as we do not track the count of users for such addons.
For better reference :

It is for this addon.
"No users" in this image should not be there, but it is only for search-type addons.
If you still have any doubts, feel free to ask here ! :)

[sresthas]

This is my first time contributing to open source, could someone please tell me why are the tests failing?

[sresthas]

So I figured out why the lint test was failing, and have made a commit to fix it, but now the test CI is failing, even though I have removed the test for 'average daily users' from tests/unit/amo/components/TestAddonMeta.js

[sresthas]

@willdurand please review #7435

[championshuttler]

Hi @twisted-sres thanks for the Pull request , today is Sunday , most of the staff is on holiday so lets wait for tomorrow for review 😃

[sresthas]

Please review @willdurand

[sresthas]

I was wondering if we should file an issue to hide user count for search tools from search results page because it shows 0 users for all of them.

[willdurand]

I was wondering if we should file an issue to hide user count for search tools from search results page because it shows 0 users for all of them.

Good call, we should probably do that too

[sresthas]

@willdurand Should I file the issue?

[willdurand]

@willdurand Should I file the issue?

Yes please

[willdurand]

Thanks @twisted-sres!

[ioanarusiczki]

@twisted-sres I verified this on AMO dev with FF64 (win10) - the search tools no longer display on their detail pages the number of users. The other extensions do not seem to be affected by this change.

@willdurand I've also notices there are users with 2 or more search tools listed, in that case on the detail page, in the "More extensions by" section, the 0 users is still visible. I filed it here https://github.com/mozilla/addons-frontend/issues/7510

Also, on all AMO servers if I filter the search tool page by Most Users the first 6 will display a number (other than 0). But indeed, most of them don't have this information.