Addons-frontend: Specified version of Node in .nvmrc is incorrect

[SeanPrashad]

Describe the problem and steps to reproduce it:

STR:

1. Cd into the addons-frontend repository
2. In a shell, run nvm use
3. Next, run yarn in the same shell
4. Observe the error message from yarn

Recently I found that the nvm docs had a section for automatically switching node versions if a .nvmrc file existed in the current shell directory for zsh.

After successfully setting that up, I noticed that the version for this project found in .nvmrc is still 6 when yarn requires >= 8.10.

See below for more details:

What happened?

yarn was unable to install dependencies for this project.

What did you expect to happen?

All dependencies would be installed, if necessary.

Anything else we should know?

This should be reproducible on Mac, Windows, and Linux if nvm is installed.

As per the docs found here, the requirements state that users must have Node 8.x which is the current LTS. Let's also update that to say something like Node 8.10!

[SeanPrashad]

This comment has a command that would help us update the correct node version inside .nvmrc without having to guess at all 😀:

node -v > .nvmrc

It would make sense to checkout the correct version of node (nvm use 8.11.3) then run the above command which should update .nvmrc's contents to be v8.11.3!

Running the command to update the node version inside .nvmrc

[SeanPrashad]

I'd like to help a friend land this as his first ever OSS patch if that's cool 😌

[rebmullin]

I never noticed this .nvmrc file:)

[rebmullin]

I think we want to keep the same format that we already see:

• 8.x in the docs (to match the release names here)
• 8 in the .nvmrc file.

We are not on 10 yet but it seems like we should do that soon!

@willdurand @kumar303 - what do you think?

[kartik-budhiraja]

@rebmullin yes, that's what @SeanPrashad helped me find out that we are on 10 yet , and that's why it was blowing up. I can commit with version '8' in .nvmrc.

[SeanPrashad]

Version 8 LTS seems to be the way to go - there are new funky stuff in 10 that will require upgrading and it looks like the team already has plans for Q1 of 2019!