Addons-frontend: The select box to add an add-on to a collection should be hidden until the collection is saved

[bobsilverberg]

On the Add a Collection screen (https://addons-dev.allizom.org/en-US/firefox/collections/add/) we should hide the select box that is used to add an add-on to the collection before the collection is saved. It serves no purpose when creating a collection.

[xu3u4]

Hi may I take this issue?
I want to try to fix it.

[willdurand]

Hi @xu3u4, yes of course! The "select box" is the autocomplete search for add-ons.

[ioanarusiczki]

This is verified fixed on AMO dev with FF60 (Win10).

@bobsilverberg What I've noticed:

1. The placeholder text on the right side before saving the collection is "Please save your collection and then you can add add-ons to it" - there were discussions it should be "Please save your collection and then you can add extensions and themes".
2. I think that after creating the collection the "Edit this collection" link should be more explicit - "Edit this collection to add/remove extensions and themes".
3. When a collection was created using the old form, once the name was typed in the Name field the URL was automatically completed with that name, with the possibility to later edit URL (to avoid duplicates).

Please let me know if I should file a separate issue for the ideas mentioned above.
Thanks!

[bobsilverberg]

This is verified fixed on AMO dev with FF60 (Win10).

Thanks @ioanarusiczki!

@bobsilverberg What I've noticed:

1. The placeholder text on the right side before saving the collection is "Please save your collection and then you can add add-ons to it" - there were discussions it should be "Please save your collection and then you can add extensions and themes".

That will be updated via https://github.com/mozilla/addons-frontend/issues/4918

1. I think that after creating the collection the "Edit this collection" link should be more explicit - "Edit this collection to add/remove extensions and themes".

We're changing the workflow, as documented at https://github.com/mozilla/addons-frontend/issues/4977, so this should become a non-issue.

1. When a collection was created using the old form, once the name was typed in the Name field the URL was automatically completed with that name, with the possibility to later edit URL (to avoid duplicates).

This is being addressed via #4919