Addons-frontend: Theme icon from "All written reviews" page is too small

[ValentinaPC]

Steps to reproduce:

1. Load "All written reviews" page for a theme on device i.e. https://addons-dev.allizom.org/en-US/android/addon/one-piece-luffy-and-sun-256856/reviews/
2. Observe theme icon

Expected results:
Theme icon is aligned.

Actual results:
Theme icon is smaller than extensions icons from the same page and is not aligned with theme title and author.

Notes/Issues:

• reproducing on moth mobile pages and new desktop pages.
  Verified on FF53(Android 7.1.2, Win 7). Issue is reproducing on all AMO servers.
  Screenshots for this issue:
  
  

[aayushsanghavi]

@ValentinaPC should the review list header look like this -

The image has to have a height and width equal to the height of the text divs?

[ValentinaPC]

@aayushsanghavi I think it should look like that, but let's ask @tofumatt .
Matt, what do you think about this?

[tofumatt]

Hi there, sorry my late reply.

Yes it should look like that, at least aligned like that... the icon is 32px x 32px so it shouldn't be stretched anymore than that. 32px icons already look blurry on modern devices with retina and better screens.

[aayushsanghavi]

@tofumatt should we resize all theme header icons to 32x32, for uniformity? What do you suggest?

[tofumatt]

Yes. We shouldn't be stretching them beyond the file size; preferably we should have higher resolution files but that's a whole thing...

Maybe we do and I'm just seeing bad add-ons. Can you find add-one whose icons are above 32px?

• Matthew Riley MacPherson (sent from mobile)

On 22 Jun 2017, at 07:57, Aayush Sanghavi [e-mail] wrote:

@tofumatt should we resize all theme header icons to 32x32, for uniformity? What do you suggest?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[muffinresearch]

See also https://github.com/mozilla/addons-server/issues/5805

[vcarciu]

Verified as fixed :