Addons-frontend: Support non-JWT authentication tokens for login/logout

Created on 22 Mar 2017  路  7Comments  路  Source: mozilla/addons-frontend

Here are some different scenarios to test this change:

  • log in, make sure you are logged in
  • log out, make sure you are logged out
  • after logging in, navigate the site and make sure login protected actions are working

The session authentication token will no longer be a JWT as of https://github.com/mozilla/addons-server/issues/4907 so the frontend code needs to be adjusted accordingly.

verified fixed

Most helpful comment

It was fun, nevertheless. Thanks for clarification! Will check :)

All 7 comments

Steps to test this change:

log in
log out
navigate the site and make sure you're still logged in

"make sure that we are still logged in", after log out?
Should we check this on mobile pages?
Thanks!

Yes, this change was for the mobile pages so it should be checked on them :-)

I like your sense of humor, but, sorry to insist, not sure I follow - what part of "log out and make sure you are still logged in" is normal? :)

Ahaha okay I see. Sorry!

Each of those steps are separate, not one after the other. So just make sure login works, logout works, and that after login you can navigate the site and stay logged in. Sorry! 馃槃

Hah! My bad, I can see how that was really unclear now. I just updated the description.

It was fun, nevertheless. Thanks for clarification! Will check :)

Verified as fixed on AMO-dev FF52(Android 6.0.1).
I've navigated through mobile pages, being logged in or out, or tried to make actions that require to be logged in, while logged out and everything behaves as expected.
Note: A video showing this would be too long.

Was this page helpful?
0 / 5 - 0 ratings