Addons-frontend: Delete and Cancel buttons are not separated

Created on 12 Oct 2018  路  5Comments  路  Source: mozilla/addons-frontend

Followup for https://github.com/mozilla/addons-frontend/issues/6458

STR:

  1. Load AMO dev login, go to an add-ons detail page and make a review
  2. Open the detailed reviews page
  3. Try to delete the review - observe the Delete and Cancel

Actual result:
Delete and Cancel are one next the other - look attached

Expected result:
There's some space between the two buttons -the way the mocks show it

Notes:
This issue is reproducible on AMO dev with FF62- Win10 & Android 8.0
Also reproducible for developer replies

Desktop display
buttons on desktop

Android display
android buttons

add-on ratings p2 verified fixed bug

Most helpful comment

Hi @SeanPrashad thanks for your interest. Not all issues are available to work on because they may be in our critical path or may have a different priority level. If you want to work on ratings features, I have recently added more to the contrib: welcome label.

All 5 comments

Hey @ioanarusiczki 馃榿! I'd love to pick this up if that's ok

Hi @SeanPrashad thanks for your interest. Not all issues are available to work on because they may be in our critical path or may have a different priority level. If you want to work on ratings features, I have recently added more to the contrib: welcome label.

Thanks @kumar303 - I'll take a peek there

Thanks for the report, @ioanarusiczki . I used the newer multi-column feature which is supposedly supported by Firefox 62 but I guess not. I'll think of a different solution.

@kumar303 It's fixed now. I verified it on AMO dev with FF62 (Win10 & Android 8.0)

Desktop

buttons desktop

Android

buttons android

Was this page helpful?
0 / 5 - 0 ratings