Accessibility-insights-web: Disable elements don't need to meet contrast ratio requirements

[cnamal]

Go to https://developer.microsoft.com/en-us/fabric#/controls/web/combobox
Run Accessibility insights

-> A11y insights reports a color contrast issue

I opened a bug on Office UI Fabric, which pointed me to the following exception:

Inactive: Disabled or otherwise inactive user interface components are exempt from this requirement. In all other states (including when the page is scrolled) the contrast requirement is applicable.

It therefore seems like Accessibility Insights shouldn't report an issue when a label associated to a disabled input doesn't meet contrast ratio requirements.

[iamrafan]

@cnamal , thanks for filing the issue.

Yes, Accessibility Insights shouldn't be reporting this issue. We filed it (https://github.com/dequelabs/axe-core/issues/1731) with axe-core and will update you once we fix it.

[msft-github-bot]

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

[ferBonnin]

@flyingUnderTheRadar can you take a look a the bug opened in axe-core?

[ferBonnin]

dequelabs/axe-core#1731 is now closed

[iamrafan]

The fix for this issue is part of axe-core 3.4.0 release

[xugao]

@ferBonnin @iamrafan this bug is still reproing on https://developer.microsoft.com/en-us/fabric#/controls/web/combobox site. and it seems to only be fixed if the disabled element is an input.

is the axe-core not included in the latest extension yet?

[ferBonnin]

Hi @xugao we have not consumed the 3.4 axe-core release yet, but this is in our backlog. We will update this issue once we have updated the rule set.

Thanks!

[ferBonnin]

@iamrafan we have updated to axe-core 3.5.1, can you check this issue?

[iamrafan]

Hi @ferBonnin , @xugao: The issue we initially filed with axe-core has been fixed, but looks like the way this disabled control is labelled in the Office Fabric page has been changed from using <label> element & for attribute to use aria-labelledby attribute.

axe-core fails such labeling, so I filed issue https://github.com/dequelabs/axe-core/issues/2090 with axe-core.

[ferBonnin]

@iamrafan this should now be addressed in Accessibility Insights for Web Version 2.21.1 | axe-core 4.0.1; could you please confirm?

[iamrafan]

@ferBonnin Yes, this issue has been fixed. Here is the demo page: https://codepen.io/iamrafan/pen/dyMzzmo

[ferBonnin]

hey @cnamal this has now been addressed

[msft-github-bot]

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!