Accessibility-insights-web: When headers are used, no automated checks detect if there aren't exactly 1 h1 element.

Created on 10 Apr 2019  路  6Comments  路  Source: microsoft/accessibility-insights-web

Describe the bug

According to the Headers test guidance in Assessment, "If the page uses headings, an automated check will fail if the page does not have exactly one top-level heading."

However, a page that doesn't have exactly 1 top-level heading when it uses headings isn't failing a corresponding automated check.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codepen.io/anon/pen/eovjqJ (another site example: https://bbc.com)
  2. Run FastPass.

CodePen repro example

Please provide a reproduction of the bug in a codepen, if possible. Here鈥檚 how

  • Goto https://codepen.io/ for a starting codepen
  • Create a simple example of the page that you have issues with and Export that codepen or give us a link to that codepen.

https://codepen.io/anon/pen/eovjqJ

Expected behavior

One of two:

  • Headings guidance doesn't mention that automated check fails under these conditions.
    or
  • An automated check fails.

Screenshots

If applicable, add screenshots to help explain your problem.

Extension (please complete the following information)

  • OS: [e.g. Windows/Mac] Windows
  • Version [e.g. 1.140.1] 2.1.2
  • Chrome Version [e.g 71.0] 73.0.3683.103
  • Target Page [e.g www.bing.com] www.bbc.com

Are you willing to submit a PR?

If asked, will you be willing to submit a PR to fix this bug? Yes

Did you search for similar existing issues?

Did you search for similar issues in our github issues or on stackoverflow Yes

Additional context

Add any other context about the problem here.

bug resolved

Most helpful comment

Fixed.

All 6 comments

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

to fix: need to remove the note in headings test guidance. the rule mentioned is best practice.

Fixed.

Thanks, @Shobhit1!

The sentence, "If the page uses headings, an automated check will fail if the page does not have exactly one top-level heading.", is no longer in the Assessment section for Headings.

But, this sentence, "Use exactly one top-level heading. (WCAG 1.3.1)" is still on the "Guidance for Headings" page. Shouldn't the "WCAG 1.3.1" in parentheses be replaced with "best practice"?

Accessibility Insights for Web
Version 2.16.0 | Powered by axe-core 3.5.1

hi @gatosocal great point! we have filed a bug #2444 to track this change.

Was this page helpful?
0 / 5 - 0 ratings