Accessibility-insights-web: Inspect HTML button should not be disabled

[haonliu]

Describe the bug

The Inspect HTML button in the details dialog on target page should not be disabled, for accessibility concerns.

To Reproduce
Open
Run automated checks.

1. Go to any web page with a11y issue.
2. Run automated checks.
3. Click the '!' icon in the target page.
4. See Inspect HTML button is disabled.

Expected behavior

Inspect HTML button should not be disabled. User should be able to interact with it.

Screenshots

If applicable, add screenshots to help explain your problem.

Extension (please complete the following information)

• OS: Windows
• Version: staging 2.1.2
• Chrome Version [e.g 71.0]
• Target Page: any

Are you willing to submit a PR?

yes

Did you search for similar existing issues?

yes

Did you search for similar issues in our github issues or on stackoverflow
yes

Additional context

[msft-github-bot]

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

[Shobhit1]

@haonliu Isn't the Inspect HTML button supposed to be disabled till the time user manually opens the dev tools (F12) ? Can you please provide more context on this issue?

[ferBonnin]

@Shobhit1 behaviour should be similar to the file bug button, the message and alert that you need to open dev tools appears after you interact with the button

[Shobhit1]

@Shobhit1 behaviour should be similar to the file bug button, the message and alert that you need to open dev tools appears after you interact with the button

Thanks @ferBonnin . I will take a look if I can take this one up today. 😺

[Shobhit1]

Taking this one.

[Shobhit1]

Created PR #859 for it.

[Shobhit1]

@ferBonnin / @haonliu Can you please verify this and close the bug if its fixed?

[ferBonnin]

Looks good to me :)