Zulip-desktop: Make the org tab list draggable in left sidebar

[akashnimare]

We should make the organization list in the left sidebar draggable so that users can reorder the added organizations.

Something like this -

On a technical level we need to make following changes when the user drags the org tabs -

• Update the index of org in the menu item

• Update the index of org in the left sidebar

• Update the tooltip

[timabbott]

sortable.js is usually the way to do this sort of reordering.

[kanishk98]

@zulipbot claim

[kanishk98]

@timabbott I'm sorry, I don't understand. What do you mean when you say sortable.js? I can't find any file by that name in the repo.

[abhigyank]

sortable.js is a JavaScript library for reorderable drag-and-drop ( they have a repo on GitHub) . Akash has already done a lot of work on this, you can check out the org-tab-drop branch in this repo and then continue from there.

[akashnimare]

@kanishk98 yeah the dragging part is done in the org-tab-drag. The remaining part is -

• Update the tooltips
• Update the index of the orgs

[kanishk98]

I've been trying to solve the tooltips problem, and I'd like some clarity here:
the initTabs() method in app/renderer/js/main.js calls initServer() using the following code:

const servers = DomainUtil.getDomains();
if (servers.length > 0) {
    for (let i = 0; i < servers.length; i++) {
        this.initServer(servers[i], i);
        DomainUtil.updateSavedServer(servers[i].url, i);
        this.activateTab(i);
    }

If we're looking to update the server icons, should we also be changing the json file containing domain information?
(Since DomainUtil.getDomains() uses that file to pass domains to servers)

[akashnimare]

I think in order to get everything right, we gotta save the index of the domain otherwise it would be difficult to keep track of all the indexes after dragging/reloading etc.

[zulipbot]

Hello @kanishk98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[kanishk98]

I'm still on the issue, just been unwell these past few days. The cold's got to me, sorry. I'll get back to work on this tomorrow.

[manavmehta]

@zulipbot claim

[zulipbot]

Hello @manavmehta, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

[manavmehta]

@zulipbot I have already made two PRs that are pending for review. Also I am working on both of the issues.
Please allow me to take this one up too.

[abhigyank]

@manavmehta sure go ahead. I would suggest to build up on PR #617.