Zulip-desktop: Menubar text colour illegible -- should respect system theme

[skewty]

---

• Operating System:
  
  
  
  • [ ] Windows
  
  
  • [x] Linux/Ubutnu
  
  
  • [ ] macOS
  
  
• Clear steps to reproduce the issue:
• Install Ubuntu 19.04
• Leave the theme as default Yaru
  
  
  
  • The menubar font color seems to be legible if Yaru-dark theme is selected.
  
  
• Install Zulip 2.4.0 from PPA
• Relevant error messages and/or screenshots:
  

[akashnimare]

@vsvipul, @kanishk98 can you folks reproduce this?

[kanishk98]

Don't have immediate access to a Ubuntu system right now, but will check it out as soon as I can.

[vsvipul]

Has been illegible for me as well, since the beginning.. I am on Ubuntu 18.04 . Though @skewty 's menu bar seems to be more illegible.

[kanishk98]

Seems like a consistent problem.
If we can figure out a way to change the colouring of the menu bar, I remember checking out this module for use in Zulip on Linux to determine the background colour of the theme and changing colours accordingly. Could this method be useful?

(I don't think Electron offers a native API to change the appearance of the title bar though, so that would have to be designed by us if we're choosing the CSS route)

[akashnimare]

As far as I know, there is an API available for macOS to detect the theme but sadly no APIs for Linux/Windows. @skewty can you reproduce this issue in other apps which are based on electron?

[vsvipul]

@akashnimare upgrading the electron version to 3.1.6 fixed this for me as shown. Can we bump up the version, should i send in a PR?

P.S. this was fixed here, and thus requires updating the electron version, as this might not be backported to current version 3.0.1, as far as i could find.

[akashnimare]

upgrading the electron version to 3.1.6 fixed this for me as shown. Can we bump up the version, should i send in a PR?

Okay, good to know this but hold on we have to test lots of stuff before upgrading to a new version of electron and we are also in the middle of a release.

[abhigyank]

Should be fixed in the v3.1-beta release. @skewty Can you check?
Can be closed if works for everyone.

[skewty]

Sorry, the company I work for purchased on-site Mattermost and we moved to that platform so I no longer have Zulip around for testing.