Zulip-desktop: Internal zulip links should be opened in-app

[jjst]

I think there is one exception to #9 where we want to open links in-app rather than in an external browser window: for zulip internal links, e.g. when linking to another stream.

For example, clicking on https://zulip.com/#narrow/stream/test-bot/subject/rsvpbot from the electron app will open a new tab in my browser, but I think it should update the current view of the zulip electron app instead.

[timabbott]

yeah, I agree that's probably how this should work.

[akashnimare]

@jjst @timabbott Fixed it. Can you guys confirm it? You will have to npm install before running app.

[jjst]

Just tested it, I can confirm it now opens the links in-app.

[jjst]

I think this regressed. I'm using fa4172281d824253ad2e2391a7dc1ef69910e0ed and internal links open in-browser while external links open in-app.

[akashnimare]

@jjst got it. It's not working as expected. I don't know what went wrong from 33fb06c to fa41722. Could you debug this?

[akashnimare]

Internal links works fine but now external links are also opening in app.

[alkuzad]

links to sites opens in app instead of browser/new tab so I can not follow them

[akashnimare]

@alkuzad external links are still opening in app. I am working on this.

[akashnimare]

@jjst @alkuzad hopefully it should work now. Can you guys test it?

[jjst]

Can confirm it behaves as it should now. Also I'm loving your use of emojis in :octocat: commit messages! :grinning:

[akashnimare]

@jjst finally :stuck_out_tongue:, emojis are great way to show your current state of mind :neckbeard: .

[alkuzad]

@akashnimare works, thanks for this