Xud: [Concept] Positive reputation

[moshababo]

Need to decide whether we want to apply positive score to peers (mostly for successful swaps and fee payment), or continue with the current, negative-only approach. It's mostly to know whether we need to do some semantic changes in the code.

Also, whether we want to call this a reputation system, considering it's local only.

[moshababo]

@kilrau the reputation isn't merely for blacklisting. It's also to prioritize between peers.

[sangaman]

I like the idea of positive peer scores. As for whether it's a reputation system, I don't think that's exactly the best term since it would in fact be local. I think just calling it something like a "peer score" is fine, and it starts at zero and can move in either direction.

[kilrau]

• constantly add new peers to the host table on discovery
• write host table to disc
• try to connect to host table on startup
• every failed connect decreases reputation by 10, every successful connect increases by 10, same with successful/failed swap + certain score (-100) results in permanent disconnect
• support whitelist mode in future: only connect to host table, which comes from xud admin, only allow incoming connections from host table
• host table: pub keys (problem to solve: many to many relations)

[kilrau]

increasing reputation = add positive reputation & potentially remove old neg reputation

clearly define positive & negative events

@michael1011 please link to events in code

[sangaman]

470 introduced positive score for successful swaps, I think we can close this.

[michael1011]

@kilrau We have one positive event right now which is a successful swap.

I can't think of any other positive events right now so I agree with @sangaman to close this issue.