Xud: Improved buy/sell output for xucli

Created on 30 Oct 2018  路  3Comments  路  Source: ExchangeUnion/xud

As per https://github.com/ExchangeUnion/xud/issues/612#issuecomment-434207811 we aim for the following output format:

xucli buy 0.0005 LTC/BTC market --stream

market order accepted
matched with peer order : .......
attempting swap: .....
swap failed: .....
peer order removed from book: .....
attempting swap with: .....
swap failed: .....
peer order removed from book: .....
attempting swap with: .....
swap failed: .....
no more matches found
quitting.

Successful case:

xucli buy 0.0005 LTC/BTC market --stream

market order accepted
matched with peer order : .......
attempting swap: .....
swap succeeded: .....
done.
P1 command line (CLI)

Most helpful comment

This is an extension of #558, and a prerequisite is #609. I'll work on these since it seems like it'd be fairly helpful for our testing and simnet setup.

All 3 comments

This is an extension of #558, and a prerequisite is #609. I'll work on these since it seems like it'd be fairly helpful for our testing and simnet setup.

  1. CLI will use output from grpc stream
  2. placeOrder (buy/sell) SYNC: keep current events, add swap failure event -> @sangaman make sure only meaningful (results) events are in the SYNC response

Per our discussion on the weekly call I'm thinking of leaving out the "attempting swap" event because it does not exist on our grpc call. Maybe that could be for a future enhancement although I don't think it's really necessary as it has little to no value for anything but the cli, and even for the cli it is just cosmetic.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

moshababo picture moshababo  路  5Comments

kilrau picture kilrau  路  5Comments

kilrau picture kilrau  路  4Comments

kilrau picture kilrau  路  6Comments

kilrau picture kilrau  路  6Comments