Xud: Store an external address if we successfully make an outgoing connection

[kilrau]

Store an external address if we successfully make an outgoing connection even if the other peer doesn't advertise a listening address, add "notAdvertised" or similar in this case -> don't share this address with others

[sangaman]

One thought that occurred to me is that if we store the last connected address along with the other listening addresses, we'd be sharing that node and address to others. Maybe we should have a separate column in the table lastAddress or something that we don't share to others. We try that address first, if one exists, then if it that doesn't work we try to connect to their advertised addresses.

[kilrau]

Tag last successful address of a peer in separate issue: https://github.com/ExchangeUnion/xud/issues/442

[sangaman]

@rsercano This might be a good one for you to work assuming @moshababo hasn't started on it, see what you think.

[moshababo]

@rsercano let me know if you want to take this one.

[rsercano]

Sure, I want to check that do I need to know anything before I start @moshababo @sangaman ?

[moshababo]

Just take some time to go through our usage of NodeList / PeerList inside of Pool. If you have any questions, feel free to hassle.