I do not have the pair btc/xuc set up on my xud (I do have xuc/btc set up though), xud is receiving order invalidations for such peer and actually tries to remove the order; which fails of course.
07/05/2020 11:24:11.754 [P2P] verbose: received order invalidation from 02778bcd8f1f578bbb2f3ff345ecccdb5865e4a08a0cfd98145da08ca3470c3e74 (ReadyAbsurd): {"id":"409fb610-9055-11ea-b76d-13690b06b3b3","pairId":"BTC/XUC","quantity":10000000}
07/05/2020 11:24:11.755 [ORDERBOOK] error: failed to remove order (409fb610-9055-11ea-b76d-13690b06b3b3) of peer 02778bcd8f1f578bbb2f3ff345ecccdb5865e4a08a0cfd98145da08ca3470c3e74 (ReadyAbsurd)
As @erkarl pointed out, this could be abused to add new pairs and flood the network (and everyone's logs) with these failure messages.
May I take this please? Want to check
you got it
Will we create another issue for GetOrders packet? @sangaman @raladev
Will we create another issue for GetOrders packet? @sangaman @raladev
https://github.com/ExchangeUnion/xud/pull/1884
This PR should fix it
Most helpful comment
https://github.com/ExchangeUnion/xud/pull/1884
This PR should fix it