Xamarincommunitytoolkit: Add Multilingual Support to the Sample App

Created on 17 Jul 2020  路  18Comments  路  Source: xamarin/XamarinCommunityToolkit

Summary

Right now the app is hardcoding the strings in the code, we should move that to an AppResource file and read the strings from there.

API Changes

  • Add a new AppResource file and move the strings

NOTE: I can add the Spanish translations and some of the community members can help us with other languages.

i18n sample-app feature-request in-progress

Most helpful comment

So, can I go for it? :P

All 18 comments

Great idea! I can add the Bosnian language 馃槃

I can add Catalan language

I can Add Arabic language so we can support "RTL", what do you think?

@jfversluis @sthewissen @AndreiMisiukevich @Depechie @all since all the strings are in a Resource file already. How we will handle this? Open a new issue for each language support, or they can just go for it add the language Resource and submit the PR?

Looks like we have:

  • Spanish
  • Arabic
  • Bosnian
  • Catalan
  • Russian
  • Portuguese

PDT:
I still have pending to add the code to change the language.

Well, I can add Russian

I would indeed suggest a PR per language... and for this first doing a suggest seems overkill? Only problem of course if 2 people do the work at the same time without knowing?
To handle that, we could do issues per language and assign it to people who want to pick it up?

Sounds good @Depechie

Yep that sounds like a good approach. Do we also have something in the sample app to actually switch languages apart from the users configured one on the device? That might be a separate issue then

Actually I was thinking to add the feature of changing the language in Runtime as part of the library using this approach -> https://devblogs.microsoft.com/xamarin/mastering-multilingual-in-xamarin-forms/
And add the ability to change the language in the Sample.
What do you guys think?

That was exactly what I mean! :)

So, can I go for it? :P

Fine by me!

I can add Pt-Br

I can help with the Spanish version

@Char0394 did you make any progress with this? I guess it also starts to make sense to maybe have issues for the different languages so we can assign individuals to that

@jfversluis yes, sorry for the delay, I'll submit a PR soon.

No worries! I didn't mean to say you should hurry up. Just checking :)

Great news!

Anyone interesting in helping with this please leave a comment here https://github.com/xamarin/XamarinCommunityToolkit/issues/225 with the language you want to add.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SunnyMukherjee picture SunnyMukherjee  路  3Comments

mhrastegary77 picture mhrastegary77  路  3Comments

rdelrosario picture rdelrosario  路  3Comments

varyamereon picture varyamereon  路  4Comments

davidbritch picture davidbritch  路  4Comments