Wp-calypso: Gutenboarding: use of theme demo site annotations creates "random" images in media library

[ianstewart]

At some point we may no longer use theme demo site annotations for Gutenboarding but in the meantime, while we do …

1. Create a new site with the Edison design in Gutenboarding.
2. Visit the media library on your new site.
3. See a collection of images and icons that are not found in any of the blocks for your new site.

This is what you'll see.

These are images from the Stratford theme demo site.

https://stratforddemo.wordpress.com/

What I expected

One of two states …

• An empty media library
• A media library with images from the design selected in Gutenboarding

[ianstewart]

Related issue: #42672

[ramonjd]

I guess we could do a post-site creation wipe of the media library. Particularly since most images, at least on the homepage templates we're injecting have absolute image URLs.

The posts we create, if they have images, will come from the demo however.

When (and if) we clear the media library, we might like to only delete attachments whose parent post ids do not match the homepage post id. If that's at all possible. Sounds legit.

[ianstewart]

This is popping up regularly in every Usability Testing session of Gutenboarding. The first or second action for every participant in the Editor has been to replace images. Each user sees a set of random images when they (seemingly, from what they seem to say) expect to find samples images that should work well with their design they've selected.

[ramonjd]

The first or second action for every participant in the Editor has been to replace images.

Thanks @ianstewart

I'll see if @Automattic/ganon can come up with a provisional solution.

This, as folks know, is just headstart doing its job: adding the required images for the theme's annotation.

I wonder if this could be solved by creating headstart annotation from the starter sites themselves instead of using the themes' existing config. It might solve a few problems at once. See: https://github.com/Automattic/wp-calypso/issues/43363

[ianstewart]

Ah — this is what I was suggesting the other day. With Headstart we _can_ create an annotation of any arbitrary site. And we can also use Headstart to push all that content and those settings to any other WP.com site.

[ramonjd]

Been testing over here: https://github.com/Automattic/wp-calypso/issues/43363#issuecomment-646443895

Result of D45183-code (selecting Cassel)

[ianstewart]

That's much more inline with what I think would be expected! Looks like we have at least one stray image in the source site but that's easily fixed.

[ramonjd]

Will mostly be addressed by Automattic/view-design#54 and regeneration of annotations over at D45183-code

[ramonjd]

Ready for testing D45183-code

[ramonjd]

Deployed in D45183-code