Wp-calypso: Jetpack Plans: can't activate plugin that is already installed on multisite

Created on 3 Mar 2017  路  3Comments  路  Source: Automattic/wp-calypso

Steps to reproduce

  1. Starting from a sub-site, part of a multisite network, as an admin with permissions to admin that subsite and no other. VaultPress should already be installed on the multisite network, but not activated on the sub site. In the Multisite settings, admins should be allowed to access the plugins menu and thus activate or deactivate plugins available in the network.
  2. Connect Jetpack to WordPress.com and purchase a plan during the connection process.
  3. Go back to Jetpack > Settings and click on the "Set up" button in the VaultPress card to install VaultPress.
  4. You'll get the following error:

screen shot 2017-03-03 at 19 09 38

In this situation, the site owner has the necessary permissions to activate the plugin, so we should do it for them instead of returning an error.

FixTheFlows Jetpack Plans [Pri] Normal [Type] Bug

Most helpful comment

I've done a significant amount of exploration around this issue, much of which can be observed in #23168 and #23174.

This was much too big for hack week. Considering this issue outside of hack week, there's still a large amount of work required to lay the foundations for a fix like this (#23174). These are major changes just to get things in a state where the relevant improvements could be made. I suspect there are an extremely small number of users who would be affected by an improvement like this, given the requirements:

  • Multi-site
  • Administrator of a site which is not the main site
  • Plugins enabled for the network
  • Already installed and just need to be activated:

    • Akismet: likely this will be installed as it ships with WordPress.org

    • VaultPress: less likely this will be installed

I think there is valuable refactor work in #23174 which was inspired by this issue, but I think dedicating the amount of time required to fix this particular now would be better spent focusing on other work.

All 3 comments

The UI appears to have been updated, now we wind up here for multi-site:

manual-setup

Note that in this case, our auto-config should ideally be more resilient/intelligent and detect that it doesn't need to install the plugin (it's already there), so then it should just try to activate and configure it (which seems like it _should_ work in this scenario).

I've done a significant amount of exploration around this issue, much of which can be observed in #23168 and #23174.

This was much too big for hack week. Considering this issue outside of hack week, there's still a large amount of work required to lay the foundations for a fix like this (#23174). These are major changes just to get things in a state where the relevant improvements could be made. I suspect there are an extremely small number of users who would be affected by an improvement like this, given the requirements:

  • Multi-site
  • Administrator of a site which is not the main site
  • Plugins enabled for the network
  • Already installed and just need to be activated:

    • Akismet: likely this will be installed as it ships with WordPress.org

    • VaultPress: less likely this will be installed

I think there is valuable refactor work in #23174 which was inspired by this issue, but I think dedicating the amount of time required to fix this particular now would be better spent focusing on other work.

Was this page helpful?
0 / 5 - 0 ratings