Wp-calypso: GuidedTours: WebPreview spinner obscured by step on mobile

Created on 31 May 2016  路  3Comments  路  Source: Automattic/wp-calypso

Raised in https://github.com/Automattic/wp-calypso/pull/5693#issuecomment-222746055

The spinner inside the preview at mobile sizes is a bit too high, and in the tour gets hidden behind the dialog (screenshot without dialog).

Guided Tours [Type] Bug

All 3 comments

Unclear whether moving the spinner for this one case makes sense. The CSS has a special case for the vertical positioning of the spinner on mobile, which moves it further up:

.web-preview .spinner {
    margin-left: -10px;
    position: absolute;
        top: 45%;
        left: 50%;

    @include breakpoint( "<660px" ) {
        top: 20%;
    }
}

The step doesn't obscure the spinner at 50%:

screen shot 2016-06-03 at 3 22 32 pm

@shaunandrews @folletto any opinions on whether we should move the spinner down? We don't want to have a special case in which we move the spinner down only if a tour is running. That would be sad.

Thanks for digging that up! I checked the line and the PR and it seems it was an implied cosmetic choice, not fixing any bug or avoiding something.

I'd probably just remove the breakpoint for the spinner in the component.

@folletto thanks, PR is #5784.

Was this page helpful?
0 / 5 - 0 ratings