Wordpress-seo: [BUG] Block schema doesn't output when block is nested within other blocks

Created on 30 Sep 2019 · 19Comments · Source: Yoast/wordpress-seo

Please give us a description of what happened.

Our FAQ and HowTo schema doesn't output when the FAQ or HowTo block is nested within another block (e.g., in a Columns or Cover block).

NB: When testing with the Gutenberg 6.5 plugin, also applies to Group blocks.

Please describe what you expected to happen and why.

Our schema logic should trigger whenever the relevant blocks are in the page; not just when they're at the top-level of the page content.

How can we reproduce this behavior?

Add a Group, Columns or Section block to a new post.
Add a HowTo or FAQ block within that block.
View the source code; note that the HowTo/FAQ schema is missing from the graph.

Technical info

If relevant, which editor is affected (or editors):
[ ] Classic Editor
[x] Gutenberg
[ ] Classic Editor plugin

* Which browser is affected (or browsers):
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Other

Used versions

WordPress version: 5.2.3
Yoast SEO version: 12.1
Relevant plugins in case of a bug: N/A
Tested with theme: Twenty Nineteen

Schema gutenberg schema (JSON+LD) minor

Source

jono-alderson

Most helpful comment

Assumption is correct. We're currently only looping over the unnested blocks.

Would be fairly simple to recursively loop over inner blocks.

This loop: https://github.com/Yoast/wordpress-seo/blob/trunk/frontend/schema/class-schema.php#L188

Should be moved to it's own function which recursively calls itself with $block->innerBlocks if they've been set for each block.

herregroen on 30 Sep 2019

👍3

All 19 comments

My assumption is that our parsing only skims the top-level structure of the page content, rather than traversing the whole structure. Likely needs some architectural consideration (e.g., do we want to whitelist block types for traversal, or just consume _everything_)?

jono-alderson on 30 Sep 2019

Assumption is correct. We're currently only looping over the unnested blocks.

Would be fairly simple to recursively loop over inner blocks.

This loop: https://github.com/Yoast/wordpress-seo/blob/trunk/frontend/schema/class-schema.php#L188

Should be moved to it's own function which recursively calls itself with $block->innerBlocks if they've been set for each block.

herregroen on 30 Sep 2019

👍3

I just ran into this as well where when creating a page with Atomic Blocks and sticking the FAQ in the AB Advanced Column the schema output was not being generated.

ScottTravisHartley on 16 Nov 2019

Please inform the customer of conversation # 568926 when this conversation has been closed.

amboutwe on 19 Dec 2019

Hi team. Any update on this bug? Alternatively, can you suggest a workaround to fire this schema mark-up?

jonnycorlett on 8 Jan 2020

It looks like this will be fixed with the release of the indexables feature. Release date is unknown though.

Djennez on 8 Jan 2020

Team - Is this fixed now? Just saw this in email from Yoast:

Schema in Yoast SEO

_Earlier this week, we launched Yoast SEO 12.8. This release featured a number of bug fixes and performance enhancements. One of the additions was an improvement to the way developers can hook into our elaborate Schema structured data implementation. This makes it easier to get your site-specific Schema inside the structured data generated by Yoast SEO. Our state-of-the-art Schema implementation — including the FAQ and How-to content blocks — is freely available for all users of Yoast SEO.

jonnycorlett on 12 Jan 2020

We just installed 12.8 and still not fixed.

jonnycorlett on 14 Jan 2020

Team - Any progress on this? I'm getting desperate. Please... 🙏🙏🙏

jonnycorlett on 12 Feb 2020

Can confirm this is still an issue in 13.1.