Wire-ios: Dark theme is not available on iPad

Created on 13 Feb 2018  路  5Comments  路  Source: wireapp/wire-ios

Checklist (please check before submitting)

  • [x] I checked the existing issues, and the issue was not reported before.

The problem

Dark theme is not available on iPad.

Environment

  • Wire version that exhibits the issue: all
  • iOS version used to run Wire: all
  • iOS device type: iPad

Details

Is there any reason why the dark theme is not available on iPad? See the code:

if UIDevice.current.userInterfaceIdiom != .pad {
    let darkThemeElement = SettingsPropertyToggleCellDescriptor(settingsProperty: settingsPropertyFactory.property(.darkMode))
    popularDemandDescriptors.insert(darkThemeElement, at: 0)
}

All 5 comments

I would love to see this!

Hey, the iPad is following the desktop version logic with the theme to simplify the development. Unfortunately there are no plans to implement it right now.

I would like to ask you to reconsider this position. It seems like an artificially imposed limitation given that the code is shared between iPad and iPhone.

Now that the desktop supports dark mode, when can we expect it on iPad?

Can someone re-open this or should I file a new issue? Now that dark mode is available on all other platforms except iPad, and you said the iPad is following the desktop version logic, this seems to be a valid issue that deserves to be tracked.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mergesort picture mergesort  路  6Comments

IpsmLorem picture IpsmLorem  路  3Comments

IpsmLorem picture IpsmLorem  路  3Comments

hprobotic picture hprobotic  路  6Comments

ujeshpatel picture ujeshpatel  路  3Comments