Wesnoth: Selecting text in wesnoth replaces "copy-paste" buffer

[vgaming]

Steps to reproduce:

1. open wesnoth // tested on v1.13.13+dev (27ec4cd316-Clean)
2. click "multiplayer" button
3. select Login text, or part of the Login text, with the mouse
4. switch to any other window and click "paste" (e.g. Ctrl V)

On my system, I get the Login text pasted. Basically whatever I select in step 3 immediately replaces my current "copy-paste" buffer.

This may be a Linux-specific thing, but my knowledge of Linux suggests it was still a deliberate action of wesnoth on said system at some point.

[AI0867]

On linux (more accurately, the X windowing system), selecting text places it in a buffer that can be pasted with the middle mouse button. This should be orthogonal to the ctrl-c ctrl-v buffer, but apparently the lines got crossed somewhere.

[shikadiqueen]

This a regression from the SDL 2.0 port and commit 358bd1235f07d8d577bdb2bb0b4aafcff2e93093 ("Remove SDL 1.2 code"). Before that, there was an X11 version of desktop::clipboard::copy_to_clipboard() used when building against SDL 1.2, which actually read the mouse parameter and set the appropriate buffer using Xlib (SDL 1.2 didn't have clipboard functionality).

Unfortunately, as far as I can tell SDL 2.0's SDL_SetClipboardText() doesn't have this functionality, and as of this writing there do not seem to be any alternatives. It intentionally sets both buffers. It seems like the best solution would be to restore the X11-specific path using Xlib and use it when mouse is true.

(For the record, gui2::text_box_base::copy_selection() and its caller gui2::text_box_base::set_cursor() set the parameter to the correct value, it's just completely ignored at the moment.)

[Vultraz]

Is this high-priority?

[shikadiqueen]

I don't feel it's terribly important myself. It's relatively inconvenient but not a deal-breaker for me (an X11 user). I can look into it after 1.14.0 is released if nobody beats me to it.

[Wedge009]

Confirmed it's specific to Linux.