Wesnoth: ATotB - Sc3, the sun is shining underground/indoors?

[Konrad22]

Basically there is this castle and the ToD is effective indoors. I think it would make more sense if it was either (regarding lighting enviroment):
a) lit floor(or however this might be called :D)
b) underground.

[CelticMinstrel]

There is an indoor "schedule" built-in, which if I recall correctly acts as a neutral (or possibly lawful?) time of day. I think it would be reasonable to apply that (or some variant thereof - obviously you shouldn't change to a lawful schedule when fighting chaotic units in their own home) with a [time_area] to the castle.

[Konrad22]

That would be neat. :)

[CelticMinstrel]

For the record, I don't like using the cave schedule for a castle, but maybe an "indoor darkened" schedule which is mechanically equivalent but uses a modification of the indoor image?

[stevecotton]

Any of these changes would need both the scenario balance checking, and (as it's the intro campaign) dialogue about time schedules. Giving a reason to discuss time schedules in the intro campaign sounds like a bonus to me.

Edit: possibly too complex to add to an intro campaign, but the time schedules aren't fixed to +25% and -25% bonuses. Having a castle where lawful is at -10% and chaotic is at +10% would be less of a disadvantage for the player.

Edit2: implemented the time zone, but not the dialogue or balancing, in the autolinked commit. This is a proof of concept, I'd welcome someone else taking over from here.

[stevecotton]

Comment from @Vultraz in #3457 - the lit stone wall terrains are deprecated, and should be replaced by a sconce on the terrain south of them. So for 1.15/1.16 the extra time zones that I've added in the commit auto-linked above should be done by (updating the map + merging #3457) instead.

[nemaara]

Fixed by #3882.

[AI0867]

I'm late to the party, but if we're adding an EASY explanation for the dark indoor ToD, we should probably also have an explanation for the sconces.

[jostephd]

@AI0867 I agree, the tip should say something about the sconces hexes being neutral ToD. File a new issue?

[jostephd]

Reopening and assigning @nemaara at her request.

[nemaara]

https://github.com/wesnoth/wesnoth/commit/371a1bacd06dfdcf7b2d8a5d781dac5d6ea0c842 should be good now.