Wesnoth: Gameplay Change: Leadership affects allies

[stevecotton]

In 1.15.0 and 1.15.1, [leadership] affects units on allied sides in addition to units on the same side. This was an unintentional change caused by #4257, but the question now is whether to make it match the old behavior, or whether to keep the new behavior.

[stevecotton]

Tagged MP as it will affect balance in 2v2 matches.

[gfgtdf]

I think it'd be better if leadership affected allied sides, (iirc i suggested this change when we were talking about the LoW mp version, where leadersip is quite weak because of this, but iirc our plan was to remove LoW eventually so that probably not the strongest point here), i'm not really a mp expert but i'd expect the 1.14 leadership behaviour kinda discourages mixing troops (and instead each player fighting on their own flank).

Also i'd assume that leadership is already weaker in 2vs2 than in a 1vs1 match with the same amount of treep simply becasue you cannot move your leadership unit along with the attacks or retreat him after if the leadersip unit and the other units are on different sides.

It'd be nice to hear more about the impact on 2vs2 because maybe there is something i didnt see maybe some strategy of one team having laedersip unit and the other team recruiting lvl0s woudl be too strong? Hard to say from here.

Lastly even if there is a reason why leadersip is too good in 2vs2, we can also do a compromise like only increasing up to 25% for allied units.

[soliton-]

I would not change how default leadership works and needlessly break UMC. If we want allied leadership that's already been possible.

I don't think allied leadership will change balance too much. As gfgtdf pointed out it's hard to use intentionally so it's not going to be applicable very often. I would certainly not make it more complicated by having allied leadership work differently.

Another criteria is does it make sense? I think usually it does not.

[Konrad22]

(It's probably not important, but this change also affects 'inspire' from THoT.)

[jostephd]

It'd be nice to hear more about the impact on 2vs2 because maybe there is something i didnt see maybe some strategy of one team having laedersip unit and the other team recruiting lvl0s woudl be too strong? Hard to say from here.

Ask on the forum? There are probably players who could weigh in on this who don't follow github.

[sevu]

The impact is relatively low. I'd see is as a nice side-effect of the code change.

[soliton-]

It'd help if you explain why it's nice. That's what this issue is about.

Perhaps I should repeat that it was already possible before. The code change was not needed to make it happen.

[jostephd]

I just fixed #4257, so leadership no longer affects allied sides in master. Leaving this issue open in case we want to make that change deliberately.