Webiny-js: Improve admin app navigation

Created on 23 Sep 2020  Â·  21Comments  Â·  Source: webiny/webiny-js

This is:

  • Feature request

Detailed Description

Our current navigation in the admin app needs several improvements:

  • [ ] Convert bottom items (links to source, community, etc) to plugins, so users can remove/override those in their projects
  • [ ] Fix API Information icon to match the style of other navigation icons

This is the part of navigation I'm talking about:
image

feature good-first-issue hacktoberfest improvement

All 21 comments

On this one, let's also replace community with slack.

i have to change api icon from code or i can post the image here?

@Lavish-Garg the API Information icon is an SVG, but its size doesn't match the other icons below it. THere is something wrong with the width, or something. You'll need to change it through code.

I am Taking up this issue

Hi @Pavel910, I would like to work on this issue.
Can you please assign it to me?

@Pavel910 why arent we using <Link> from @webiny/react-router in Footer? I can take up this issue can make changes.

@aloks98 because <Link> is mostly for public apps where we have internal links pointing to, say, Page Builder pages. That component then preloads data for faster page transitions. In admin app such routes do not exist, so we don't use it there.

Hi, can you please confirm if you are working on the issue? If you are on progress, let us know, we will assign it to you. If you decide to not work on the issue, the next person will get the assignment. We need confirmation from everyone in order:

  • [ ] @Lavish-Garg
  • [ ] @lokeshvenkatesan
  • [ ] @ShyamPraveenSingh
  • [ ] @aloks98
  • [x] @BhuwanChandra

Hey @AlbionaHoti If no one is working on this issue, I would like to take this. please assign this to me.

Hey, @BhuwanChandra you are on the list, next @aloks98 - We will wait for a confirmation and decide on the assignment. Meanwhile, did you follow up on the Contributing.md guides to set up Webiny locally?

@Pavel910 i am open to work on this issue, and yes, I have set up webiny locally. I have been working on another issue too and about to complete it. 😄

@aloks98 Please reach out again when the other issue is complete and merged. Until then, this issue is open for other contributors, if any :)

@AlbionaHoti if this is open, I would like to work on it!

@BhuwanChandra you can continue on the issue. Please post an update of where you think the problem is after diagnosing it and the solutions you tried (communication here is key) - Join our slack community to communicate faster with the community and the core team. Enjoy :)

I am working on this issue. Please send me slack join link. Thank you.

On Wed, 7 Oct, 2020, 9:04 pm Albiona, notifications@github.com wrote:

@BhuwanChandra https://github.com/BhuwanChandra you can continue on the
issue. Please post an update of where you think the problem is after
diagnosing it and the solutions you tried (communication here is key) -
Join our slack community to communicate faster with the community and the
core team. Enjoy :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webiny/webiny-js/issues/1259#issuecomment-705017700,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOS227CHNZ5RVWIDNRCJMTSJSC7PANCNFSM4RWZNEBQ
.

@lokeshvenkatesan Please join Slack :slightly_smiling_face:

@lokeshvenkatesan @BhuwanChandra is working on this issue, until we have an update from him on the progress we can't assign the issue to someone else. Thank you.

@AlbionaHoti I did the local setup of webiny, also went through the code files and looked at where to make changes to solve the issue. I am working on it and will make a PR soon.

@AlbionaHoti I have created a PR #1298 for this issue, can you review it and suggest some improvements(if any)?

@BhuwanChandra thank you very much for the PR, our team member @Ashu96 will get back to you later today with feedback!

Sorry to mention.
We have been suffering from Pandemic and we are struggling to cope up.
I am interested in getting webiny swags and due to pandemic I am not able
to complete the work.

Let me know what's need to be done for minimum requirements to obtain
webminy swags .

Sorry for delay. Regret for the inconvenience.

Thank you
Lokesh

On Mon, 19 Oct, 2020, 9:24 am Ashutosh, notifications@github.com wrote:

Closed #1259 https://github.com/webiny/webiny-js/issues/1259 via #1298
https://github.com/webiny/webiny-js/pull/1298.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webiny/webiny-js/issues/1259#event-3891181794, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOS22ZT5D2JDTNBIVFSKVLSLOZ6BANCNFSM4RWZNEBQ
.

Was this page helpful?
0 / 5 - 0 ratings