Webiny-js: Content Model validation message not show in the dialog

[Pavel910]

This is:

• Bug

Expected Behavior

When an invalid model name is specified, for example 3D Asset, a validation message should be shown under the Name input.

Actual Behavior

Validation fails with a very obscure Validation failed error:

Steps to Reproduce the Problem

1. Open New Model dialog
2. Enter 3D Asset for model name
3. Click Create

Possible Solution

The validation message should be show in the form, ideally beneath the name input. The validation could also be performed on the client side, to avoid form submission all together.

[WioZak]

I'd like to be assigned to this issue. Participating in Hacktoberfest, first-timer in open-source.

[Pavel910]

Hey @WioZak! Welcome! Here are some links to get you started:
Some instructions about contributing: https://github.com/webiny/webiny-js/blob/master/docs/CONTRIBUTING.md
Our YouTube channel with different videos about the project, how stuff works, etc: https://www.youtube.com/c/Webiny/videos

Regarding the issue:
https://github.com/webiny/webiny-js/blob/master/packages/app-headless-cms/src/admin/views/ContentModels/NewContentModelDialog.tsx

We need to perform validation for the name field, via a custom validator. Validators are simple functions, and you can find an example of a custom validator here: https://github.com/webiny/webiny-js/blob/master/packages/app-form-builder/src/admin/components/FormEditor/Tabs/EditTab/EditFieldDialog/GeneralTab.tsx#L71

This is the validation logic that we're performing on the API side, and it would be nice to do this same check on React side:
https://github.com/webiny/webiny-js/blob/master/packages/api-headless-cms/src/content/plugins/models/ContentModel/idValidation.ts

If you have any questions, please do leave a comment or reach out via Slack, it's a lot faster :)
Cheers!

[josselineperdomo]

Hello! Does @WioZak still working on this issue or is this available? I'd like to work on this :)

[AlbionaHoti]

@WioZak can you please post an update of your progress on the issue and the solutions you tried (communication here is key) - Join our slack community to communicate faster with the community and the core team. Enjoy :)

@josselineperdomo if @WioZak can't continue with the issue, we can assign it to you :)

[josselineperdomo]

Hello again! @AlbionaHoti Please let me know if I can start working on this issue :)

[AlbionaHoti]

Hey @josselineperdomo, since @WioZak didn't respond and it's been 12 days since his last activity, you can continue with the issue :)

[WioZak]

Hi! Sorry for not responding, I had issues with my hardware. If it’s ok with you, I’ll find another task.

[josselineperdomo]

@AlbionaHoti and @Pavel910 I opened a PR to solve this issue, but there is a stage in the actions which doesn't pass. Please let me know any comments :blush: