Webiny-js: Page Builder - if installing on localhost, add warning about site domain

Created on 11 Feb 2020  路  5Comments  路  Source: webiny/webiny-js

This is:

  • Feature request

Description

In the Page Builder app's installation process, users need to enter their site domain. Normally, if the app was deployed to the cloud (and being accessed via CloudFront URL), the admin and site apps will reside on the same domain. So, prefilling the site domain input with the domain over which the admin was accessed, is in 99.99% cases correct.

But in localhost, admin and site apps are hosted on different ports, and that's why we cannot just take the domain over which the admin was accessed. Usually, admin is hosted on localhost:3000 and site on localhost:3001.

Possible Solution

If the installation is happening on localhost, let's automatically prefill the http://localhost:3000 as the site domain, and also add a note to the user - saying that they should start the site app in order to double-check the port.

feature good-first-issue

Most helpful comment

I'll take this one

All 5 comments

The input is located here: packages/app-page-builder/src/admin/plugins/install.tsx:121.

The default value for the Domain field is set here: packages/app-page-builder/src/admin/plugins/install.tsx:95

I'll take this one

@Arvisix are you still working on this?
If not, I will work on this issue if it is still relevant (after the recent changes to the project I mean).

@TommyJackson85 this issue is being handled by one of our developers. @Ashu96 please confirm :) We decided to handle this one in a different way, so the issue description might be misleading, but the overall problem is being addressed.

Thanks @Pavel910

@TommyJackson85 this issue has been resolved. We will close this on shortly. 馃檪

Was this page helpful?
0 / 5 - 0 ratings