Webiny-js: Inspect / correct configurations for development tools and processes

[doitadrian]

While working on v5, I noticed a couple of things that might use some checking:

TODO:

• [ ] 1. Prettier - whole project scanned
• [ ] 2. lint-staged - incorrect file filter applied
• [ ] 3. ESLint - not ignoring build files

1. Prettier - whole project scanned

While running pre-commit actions, this prettier command takes a lot of time, because it's actually scanning the whole project, not only the files that are about to be committed.

2. lint-staged - incorrect file filter applied

This here says only "**/*.js" needs to be included. We should add ts,tsx here as well.

3. ESLint - not ignoring build files

Running yarn eslint inspects the whole project, including build files, which should NOT be happening.

[iamdarshshah]

Hey @doitadrian 👋 ,

If the issue still exists, would like to have a look into this. Let me know if someone is already working on solving this. Thanks

[doitadrian]

Sure, go ahead @iamdarshshah! 👍

Let us know for any questions.

[doitadrian]

P.S. Note that you need to branch from v5 branch, which is what we'll be working on for the following weeks.

We don't need this for master.

[iamdarshshah]

@doitadrian Sure noted. I'm on it! 👍

[iamdarshshah]

@doitadrian Check PR #1301 that will fix this issue for branch v5 & let me know if there is anything that needs to change. Thanks

[webiny-bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.