Web-stories-wp: Element link won't work while no page attachment

Created on 25 Sep 2020  ·  5Comments  ·  Source: google/web-stories-wp

Bug Description

The element link feature only work while page define page attachment.

Expected Behaviour

The element link should work w/wo page attachement.

Steps to Reproduce

  1. on a page without page attachment, add link on an element

截圖 2020-09-25 下午2 08 32(2)

  1. preview, the element link won't work
    截圖 2020-09-25 下午2 11 52(2)

  2. back to editor, add a page attachment
    截圖 2020-09-25 下午2 10 41(2)

  3. preview again, the element link works
    截圖 2020-09-25 下午2 10 52(2)

Screenshots

Additional Context

  • Plugin Version: Version 1.1.0-alpha
  • Operating System: Mac
  • Browser: Chrome

_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

Implementation Brief

Design Panel Links Bug

All 5 comments

Thanks for your report!

I see you are using our local dev environment—thanks for testing!

I really thought we had fixed this already. @miina can you take a quick look?

@lucemia I'm afraid I can't really reproduce this:

  1. Create a new story
  2. Add text element
  3. Add link
  4. Preview story
  5. Link is there

On your step 2) from your report, when you go back to the editor after previewing the story, do you still see the link option in the Design Panel? Does it look like this:

Screenshot 2020-09-25 at 11 19 38

Tried to reproduce this as well -- without luck.
The issue did exist but was fixed within https://github.com/google/web-stories-wp/pull/4323

I'm also seeing this icon on the screenshots:
Screenshot 2020-09-25 at 12 54 51

That was also removed recently -- it hints as if the version used is not fully up to date. Thoughts?

The version above says 1.10-alpha, which would be the current main branch.

Maybe need to run npm run build

@miina @swissspidy
thanks!!

after npm run build , the issue is gone.

Sorry for misleading

Was this page helpful?
0 / 5 - 0 ratings

Related issues

o-fernandez picture o-fernandez  ·  3Comments

o-fernandez picture o-fernandez  ·  4Comments

swissspidy picture swissspidy  ·  3Comments

swissspidy picture swissspidy  ·  3Comments

injainja picture injainja  ·  4Comments