Web-stories-wp: Fill button does not indicate status (toggle)

Created on 21 Apr 2020  路  3Comments  路  Source: google/web-stories-wp

Bug Description

When making an image full-bleed (fill), the button is not toggled

Expected Behaviour

The button should show the current status

Steps to Reproduce

  1. Insert image
  2. Mark as full-bleed
  3. Notice that fullbleed button does not change status to indicate that the image is fullbleed.

Screenshots

Status quo (see button on the right)

Screenshot 2020-04-21 at 16 51 31

It should be marked "active" just like the alignment button here:

Screenshot 2020-04-21 at 16 54 12


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

QA Instructions

Editing Bug

All 3 comments

@swissspidy What about flip controls? Should they also reflect the status when selected?

Kapture 2020-05-05 at 12 56 21

@obetomuniz IIRC no. But I'll let @samitron7 confirm.

Pascal is correct. It is not a toggle.

Was this page helpful?
0 / 5 - 0 ratings