Web-stories-wp: Enable the new Font Picker

Created on 12 Jun 2020  路  12Comments  路  Source: google/web-stories-wp

Feature Description

Enable the new Font Picker feature flag so it is visible by default, see Acceptance Criteria for details.

This is a combination of the following issues:

  • [x] #2205
  • [x] #30
  • [x] #1955
  • [x] #2416
  • [x] #1989
    ~- #3304~

Product Brief


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

  • The new Font Picker is enabled, including font preview, search, and recent fonts.
  • Karma tests for all these 3 features
  • Please write QA Instructions for all the parts of the new Font Picker, too

QA Instructions

See #3215

Editing Fonts Prometheus Enhancement Failed

Most helpful comment

Should this issue also perhaps include adding Karma tests for the new font picker? cc @barklund

All 12 comments

Should this issue also perhaps include adding Karma tests for the new font picker? cc @barklund

Should this issue also perhaps include adding Karma tests for the new font picker? cc @barklund

Yes please! And QA instructions for validating the entire font picker implementation (those QA instructions might serve as integration testing instructions too).

Will figure out what all is left on this and depending on - dillon or I will take it.

Update on this ticket:
1955 is in review, owned by Barklund to be reviewed by Miina
2415 in review, owned by Carlos/Brittany, to be reviewed by Barklund and Miina

@barklund or @miina - do one of you want to own adding Karma tests and documentation to the font update since it's in the editor?

@barklund or @miina - do one of you want to own adding Karma tests and documentation to the font update since it's in the editor?

Sure, once the relevant issues have been merged 馃憤

"muli" is missing from the list noted at https://github.com/google/web-stories-wp/issues/1989

Looks like "Muli" font isn't pulled into the fonts list at all, it is marked in the curated list in the code though. We can probably merge the font-picker and investigate the Muli font issue separately if needed. cc @barklund

Note: Looks like "Muli" was renamed to "Mulish" -- will replace.

Nice catch on that Miina!

IBM Plex Sans is missing from the list. Also this isn't part of the ticker but @wassgha @bmattb @barklund for the beta 2 cut we should make it a point to prioritize and fix the different styling for the dropdown

Screen Shot 2020-08-13 at 9 57 59 PM

Screen Shot 2020-08-13 at 9 57 52 PM

IBM Plex Sans is missing from the list

I cannot confirm this. See:

Screenshot 2020-08-14 at 10 37 17

IBM Plex Sans is not on the list of curated fonts shared at https://github.com/google/web-stories-wp/issues/1989#issuecomment-662253222

UAT feedback was added in https://github.com/google/web-stories-wp/pull/3215#issuecomment-673903589.

4008 and #4009 were opened based on that.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dvoytenko picture dvoytenko  路  3Comments

Maverick283 picture Maverick283  路  3Comments

injainja picture injainja  路  4Comments

o-fernandez picture o-fernandez  路  4Comments

3pgarro picture 3pgarro  路  4Comments