Walletwasabi: BUG: PSBT is too large to be signed by wasbai

Created on 2 Sep 2019  路  12Comments  路  Source: zkSNACKs/WalletWasabi

"the textbox don't accept enough chars" reported by @NicolasDorier on slack.

@yahiheb @jmacato could one of you take a look at that? Build a large transaction under the advanced wallet tab/ build transaction.

debug

Most helpful comment

@NicolasDorier Awesome, will fire up a PR right now :)

All 12 comments

For some reason, i can't repro this. @NicolasDorier can you give us any repro text to work with?

sure one sec

So

cHNidP8BAP3xCAEAAAA2d6JIEYKE5pZPFR4FYwtNc0uAKT3+1/xIzkE3RDeWTE0BAAAAAP////+XYc+89BNeo87/F3LNJ8H8FZzBzxTUYg9rQVwrY0rN9wEAAAAA/////7Ot58fAakQuzkdjFf7jMhdBtRYH5DDhpAN/sqZVUuoCAAAAAAD/////4D8a0dIneTdZstM2vxvb74P8HspWdNYcjk9vMQTuDtEBAAAAAP/////wUlvcdP7N4D+ejqy9xnQcnh3z6JLyqPGwAgjpaEfkfwAAAAAA/////5O4Z1etXwf0zk87j3LwX0Jy2D+cQnvWNxegUg1X5tEMAQAAAAD/////buXd0SOnve+ZK102bCi9K78UUupTzadzMwICJofi4gcAAAAAAP////+7h91EJLuTUUJcWx3IG19Gv2zhpci3hgEkOx61osPcdAEAAAAA/////7pqG1mU5WkFaHZwaqw2bFzs35hO2AimHYT5s5rn7mNxAAAAAAD/////YQgoIaPwmksc9JHpNMoW/AFkJKPgmd0TCy6R74nhVagBAAAAAP////84VHY4TJ4tCVXl0cc/Kz6iMxzTgGm+tQaZtwm2UcoeYQEAAAAA/////wxzyqPB0fyka/L80HOuz04ZhR6yKnuBdjF8X1cNGUjPAAAAAAD/////KAPVNQMPXzTWbQ/rX86LQ7qY6NWWuV28Htk8C+97fOgAAAAAAP////9k0bK7O+9yOZvEgv2H5oXmmDMq9TE5aS6y/h4J1bphLgEAAAAA/////9aOrGI/P5k8X5ntcpDXGzQyMpKmcfRnDdyoJkS/62hLAAAAAAD/////AKXbI/43bb1DVJ4x93f0IUt9DOAB1xkKskFbAdeA9b0BAAAAAP////9Vd4vriD0xm3Na81BvZhNQhqHorcW4k5ZSJR/55yJtZgAAAAAA/////zwF0iVB6MrqOrHw5xMt58EfvjNVWNFe6Oyvip0rtcJOAAAAAAD/////ze06uGF7j8Hf+D5AEPNXkQziHPdgLzyiIB8bo5bE1QEAAAAAAP////88WekB2hld6/Pnn3V8h2u/VeOPJSUZWYFuxI+Auir+BgEAAAAA/////+RxDzDgR6VndmjRx9bcwICkqTbsgbMNn3APVt3dRjEmAAAAAAD/////W/1x4yjc2Y9dvyj8Y676Xp9gD04EdbLw3E/O0GGOKMEBAAAAAP////+CyMB/bPcnLNTQoc7cBzuRoX1371Z6TrTE/8yhvuS+xgAAAAAA/////71/i5vaIqP8qzB42LPzjgpPmtQUgrp+iEeOlFquOSWXAQAAAAD/////F8LWjrYRW+queKVCAAGsjfytTzsBVQ6b3T7oAzKpUUwAAAAAAP////9g3AkQ9u1GCT51U/kRzYSktEkvjMSgHVrVoS0/wrWhtAEAAAAA/////yh5CjXZ6mUsRbRTDegzKwptvzpoVgyUxfDKgGXk4F2WAQAAAAD/////oBd2GOCSAgdhY9VuAXDe68BtasWC9QS65c5JscNCXn0AAAAAAP////+6tXvLAGHMLhZnAeAHdSQ93beliNCXF6eTfqVBik3MEAAAAAAA//////nn/gHqDlxoNpEpVIgJCyPwPy/7RuGbvVWWOcdDLnvyAQAAAAD/////YWDbtb+JGd7Ct4QAXFuFNrcQEnGaLGyxU9uj+Aaly2AAAAAAAP////+ONnO/N6fH8jNH7GKsOAovgvBCJVZ327TXco96pNL1NQAAAAAA/////08hQNDp8C4NKM95H2AswY1WSXmRootKjJ6/O/ti4+IdAQAAAAD/////sjTBmTrjRINLSr1oGAphbKEGV5Wg1ro8enXED+nr8kMAAAAAAP////+OVqnWMl50Rxq8n8XQa6tE+yCcCibZYWRNN/eq7L3QbgAAAAAA/////3wh4K61wgomk7V+IKbGooaPDqzjw09lp6CHvA/bjnV9AAAAAAD/////iPILIdyclorKO/DPKq44y8kacrfNVHPYpFUzDGrTkuQAAAAAAP////8h+fYUaa1WIdZ6D02IBR87GKU22QXAiiWTxBMytSRlVQEAAAAA/////xz74Q1/S5u2FWfiYZBYhhkXMA3yyr5N+f4ILW/B2+cCAQAAAAD/////V29MyNLDTmJKRwAV/1ilWt59//weXguRhJQp3g6DHukAAAAAAP////+/2vSkRvM4UJR+eP6WU76HdWsxNMkSIZHDjBI9xT84OgAAAAAA/////2zPhJwS1SwByIArMXCMuNFpVlpm/DqNwSQihD51G57fAQAAAAD/////vag1Izw+Mx3GkTG+UD/arEaHBZClaV0N72S0W2aOkJABAAAAAP/////ugRr0G2SG3tASdRNpOmz3Vl9Sf3e99ol6GXcbXn1RkwAAAAAA/////wr0MeHZGlUNgO2XuMyJNzKoG/RKHls4xhTuGfb0ATL8AAAAAAD/////m4h6W2woazBkyGEJHdWQwi6EN/+Y2OgupqYNIHDNa3AAAAAAAP////9w47bChhl/uhXNZ5rPlUs76qjLIZAiUmZgCHoWw5UFbwEAAAAA/////4ebVibUEsdrIYTSuKMv6xoJ6ULU4P1Z7tiDfCyQXub4AQAAAAD/////zzHl/rpgLwRwDDKCSWZKQv8Yr/WU8+v8JFZyj7C+F2gBAAAAAP////8wph04WDtIlb9PnLUv4ieD7LRGtTPTXR3VUa2IxDJGGwAAAAAA/////8J97ZUsTEtKErK7lNdLISm3D9OoqNSH8XAEvhAlTYpAAAAAAAD/////8CAza69BrQ6dU+ePPG7oaIBff3cENZUXH/srAA7qSOYAAAAAAP/////Zbinnfsp7lZC3sRwEUUeOSUhgnJSiBG6vZzV+7VGxTwEAAAAA/////8cC89AE5z3DMd0MoP2wQ7cHTUb2jtd9wmm5io58D8RzAAAAAAD/////AgDh9QUAAAAAGXapFPC6nH9/UKuFtvtcoa4KajXwv3uriKxgDuY7AQAAABYAFHFOAARcYRYrrOpwOZpHTyMYo4QLAAAAAAABAR8A4fUFAAAAABYAFAsjuHpmrsakyHLrt0cUQ2JhsAAhIgYDhwa/LUbEiFIbycFVoXt01hDoNoXpqaTLRBKpJKl9Tt4Yp+FU9jEAAIAAAACAAAAAgAAAAAAzAAAAAAEBHwDh9QUAAAAAFgAUdFWjqnMfSdJrh2v2TIK+D/7G7BgiBgO7P3hkpwVuEnMVgvKpMDOsX+2YHEbD8l2LNL8rr+rEhhin4VT2MQAAgAAAAIAAAACAAAAAACkAAAAAAQEfAOH1BQAAAAAWABTaTN6Ov5ojrICpTthcNExMyfHjeyIGAlm71PHiNdtOTnOjDxJl6jWS70p1zCeiSkpgOZC8f2ezGKfhVPYxAACAAAAAgAAAAIAAAAAAGwAAAAABAR8A4fUFAAAAABYAFMssjeizb/5IUB1Bf2ahrRoJFesOIgYD6VfmL/YwNqkpuvvF03ptySBXhpXUir6d4SI0QDWCy+kYp+FU9jEAAIAAAACAAAAAgAAAAAARAAAAAAEBHwDh9QUAAAAAFgAUdq9uN5FRBQIT03ECg8SXpVsJeYIiBgNbVyJPHwJFQaozm3jocIrSpl7LoOOCjC/O2DVRo9fluhin4VT2MQAAgAAAAIAAAACAAAAAAAQAAAAAAQEfAOH1BQAAAAAWABS0T0fZkRH4yB0RuJSwtRlNpYvR/CIGAkKCiJ7MroU6vrynI3gzB8TH1pB/GcTzx6FoObdXHto1GKfhVPYxAACAAAAAgAAAAIAAAAAAJwAAAAABAR8A4fUFAAAAABYAFMrHQd36IAThFmVww3y977wpE3KZIgYDb7MDT4ozUpJGIrmdfFUjscASN7Kskhj9wkw45Eei/rAYp+FU9jEAAIAAAACAAAAAgAAAAAAfAAAAAAEBHwDh9QUAAAAAFgAU0mVp0lf40WJjHdGFKJyD0vBMHrQiBgNNONDtxfqIzeF+Q1pH//ujaGT/Oqk3KKrWXSTR9Bs3nxin4VT2MQAAgAAAAIAAAACAAAAAAAAAAAAAAQEfAOH1BQAAAAAWABQMw89w+yW3idOsDF82CgyRI6uLKiIGA1QWIK3yEp8epNWdfw1KP++BaTikDGBqnQjdde8T5p7SGKfhVPYxAACAAAAAgAAAAIAAAAAAEwAAAAABAR8A4fUFAAAAABYAFJBndAQ2d1ZU2Wp8TVNBEI3GyY/qIgYCva4cGALz5d6c7crAhPi1buipxnWNFWMCJQyvMAZt79MYp+FU9jEAAIAAAACAAAAAgAAAAAAVAAAAAAEBHwDh9QUAAAAAFgAUyujuNSFSKCXbrCFrSJIdnqKqcj8iBgPX9C4aCeJVpQK9Da/skSttra9Kpo/AjlhUpWJzevzMdxin4VT2MQAAgAAAAIAAAACAAAAAAC0AAAAAAQEfAOH1BQAAAAAWABQllLEqbp3o1GWpAxyq9/OAzc+M2SIGAgBMjWLJnS6trS5I8uaFrwLLErzJYKk+Gqm+fGtkJG2PGKfhVPYxAACAAAAAgAAAAIAAAAAAFAAAAAABAR8A4fUFAAAAABYAFAOrSQlUsyVBn52J+8PenK5gUn3XIgYCrh06zU1qE5Gkdkhl1EUdP+gl8dCJiJdEk28ZzqRv95cYp+FU9jEAAIAAAACAAAAAgAAAAAAFAAAAAAEBHwDh9QUAAAAAFgAUmNTxDmI5DVdWHYwDZm4hvkzFf0ciBgOOhNsbli05UhGUha4O92ABjr5Ls970euWPrrYPrBLzJhin4VT2MQAAgAAAAIAAAACAAAAAACsAAAAAAQEfAOH1BQAAAAAWABQzrco3NEy5t+cI8N22hEkOGKfD2yIGA9wmrZhdv0+ePG8GHI02gbT3w3DXZPs4AM2CXscxEMysGKfhVPYxAACAAAAAgAAAAIAAAAAAMAAAAAABAR8A4fUFAAAAABYAFJwlCrc2iGDy+gTln2EtxxWxkmoQIgYDWIx2pWMphGLAD4ks8fcXS+MsGr1pu27RRINg5PR4qVYYp+FU9jEAAIAAAACAAAAAgAAAAAAlAAAAAAEBHwDh9QUAAAAAFgAUNE1JvFS0MjuSTFV3d/UluC99GoYiBgKi5MBagSBgBk0FWQ6Tih3SafhJuQyefNo9Pu5tx+Huixin4VT2MQAAgAAAAIAAAACAAAAAACYAAAAAAQEfAOH1BQAAAAAWABQ3kvY00CvsMwNxu+AMImk3X5lfyiIGAjzTCagzc92N1sgvYv6P4vE+HbsAvZfGNMk541qdjQQ/GKfhVPYxAACAAAAAgAAAAIAAAAAAEAAAAAABAR8A4fUFAAAAABYAFAPBMHz401h1jfE0AM/liHrtcvdGIgYCgcP3c7ArIGTr6yl4F8V3siwN0C2J9nvpfnwuP7kES1QYp+FU9jEAAIAAAACAAAAAgAAAAAAcAAAAAAEBHwDh9QUAAAAAFgAU43O20bfDN+Es8+FeK8nJ6zYUnroiBgIgg0N0DAwjMvH9Nftv3xfWLWC9fuwFaDugaZc9caxBKxin4VT2MQAAgAAAAIAAAACAAAAAACAAAAAAAQEfAOH1BQAAAAAWABRu3BkfozjPASJPsPrjKEnn885A0iIGA3XpIckRccjvJiht6feOJ1o5K2e2yUZsWHcZyrhFGIabGKfhVPYxAACAAAAAgAAAAIAAAAAAMQAAAAABAR8A4fUFAAAAABYAFG2Zf8FFKIESg4oQaLhJ8fVJ4ERkIgYDQN08/2MXU41AI6ACAXXX/Oi9tCYM/0XtvOQBTqBQNFkYp+FU9jEAAIAAAACAAAAAgAAAAAAoAAAAAAEBHwDh9QUAAAAAFgAUEC1wzXCCh2XxLI98CYtsyZIFQAYiBgIy8Xu4NTtwLh9bJEkrI6ESU//QLRtN0B7fULumXyUw4hin4VT2MQAAgAAAAIAAAACAAAAAABYAAAAAAQEfAOH1BQAAAAAWABQzJVmBSSphdZtZvAVk/66+9ldDAyIGAlpuPYBuUOuZMIaLrSLswZsq24heQg+ildcqhdisWOZ3GKfhVPYxAACAAAAAgAAAAIAAAAAADAAAAAABAR8A4fUFAAAAABYAFJ1H1S/FLaiwjGp3NzoFlXQavh7mIgYCcMy03wYI1suLfKPUq8A3OvtCKOqD8Ruk59a1OArJ5p8Yp+FU9jEAAIAAAACAAAAAgAAAAAAYAAAAAAEBHwDh9QUAAAAAFgAUuBKN1SsTQRLT1kpcMLJjJO6Fl4ciBgKhre0UjGNIit/yHxsfn+3eWSy+PWqtqArD4/mYtQ3AsBin4VT2MQAAgAAAAIAAAACAAAAAABkAAAAAAQEfAOH1BQAAAAAWABSQd9sKbL8zSMhfCbW4Kq5EXkoZnyIGAi3yymplJBDmBjuTGj8C7JrMUW7QeZLV1rEeH+NuSwq0GKfhVPYxAACAAAAAgAAAAIAAAAAAIQAAAAABAR8A4fUFAAAAABYAFNegfU6YlBpw4wDdnerjo8ahX1oNIgYCr10v54nUGMBBsIvuDUyIFaJTnFdPVDEj3Wnjz/om020Yp+FU9jEAAIAAAACAAAAAgAAAAAAeAAAAAAEBHwDh9QUAAAAAFgAUYncGTIHyTIXNP6bWo2Q+qdHuPusiBgLdTfC8V7w9F8oC1MvAL/eh1hPpIm+30/rQCCqGslsuuBin4VT2MQAAgAAAAIAAAACAAAAAAAIAAAAAAQEfAOH1BQAAAAAWABSeVqs71rN2I3F962ZQMaB9/iqJ0yIGAwEHlDQDpuND4v4MDxFLHFK3xGbyq5+2NMdHXi9dSOPnGKfhVPYxAACAAAAAgAAAAIAAAAAACAAAAAABAR8A4fUFAAAAABYAFF1OTneQlMEAQiWH2uJfRuaQu6czIgYC9Y6e+IT+eST6nMj8eaBqtNDSRDXUSVbdkOzCSwdZKCoYp+FU9jEAAIAAAACAAAAAgAAAAAAOAAAAAAEBHwDh9QUAAAAAFgAUKXZvA/jO19siRR+P7oHTp84ZI+4iBgO6Nn61nL0vENMBWYK3uxfuYHIx9AfxFJaFr/4u4KvjyRin4VT2MQAAgAAAAIAAAACAAAAAAB0AAAAAAQEfAOH1BQAAAAAWABR/gwP5/y2EWROnGuOUOK5+F8q6xCIGAunXm/C1pxh/+vny8JG6z5PgyzIJmBAO5dMrkt/X62sIGKfhVPYxAACAAAAAgAAAAIAAAAAALgAAAAABAR8A4fUFAAAAABYAFFJJdDRBsVpOF/VxyxT/771PNExGIgYDW9rNBm8ZEgsv4UQXBN7jG6OnUjELwbTAY5SXYSX74W0Yp+FU9jEAAIAAAACAAAAAgAAAAAAXAAAAAAEBHwDh9QUAAAAAFgAUTrkGdnMWt+lnhrb2mTgvVive7DUiBgKjQctIw4aLFp4mdw08bpS1b/GCM0Bk+F+nmoSgvvIqgBin4VT2MQAAgAAAAIAAAACAAAAAADQAAAAAAQEfAOH1BQAAAAAWABQe9nOxPWqnlh3KhoEqX9iQxdDUDCIGAnuKvMXsJybsKUVLiA40Fp9WDP2eKMGPQI4zOrrH1iNKGKfhVPYxAACAAAAAgAAAAIAAAAAABwAAAAABAR8A4fUFAAAAABYAFOSsLieKFyfFZ31Qfvwh4CGEjj6PIgYCOYkCr4A1yREtQSEj4SM4Y0OJQU917tNzm9cP3QcDwDMYp+FU9jEAAIAAAACAAAAAgAAAAAAaAAAAAAEBHwDh9QUAAAAAFgAUDjGgBWsLFZ2vjqc+WhLj8Utc8MAiBgLTReozeToxZ9Zze37GWR+uEHR5mnXYbLMesF8cuJcukxin4VT2MQAAgAAAAIAAAACAAAAAACQAAAAAAQEfAOH1BQAAAAAWABRiQ/lO86ik6Dsv68I6zxMDGgdMjyIGAh0Q6top23rrq+1DKMjWfQyIPdPJWH+qK0tDUuWlb9I5GKfhVPYxAACAAAAAgAAAAIAAAAAAAwAAAAABAR8A4fUFAAAAABYAFKZ+srGptb9QNy23unLb9Q7FPhSUIgYDSjKtj4MXFwgr0s5+EL7Ze5Re1kiCFQ3f1iWdfuIlSEwYp+FU9jEAAIAAAACAAAAAgAAAAAAvAAAAAAEBHwDh9QUAAAAAFgAUYkUzxcgGNlZnrbAnO6myctcXoXQiBgIDYgWCerhgP+QTz4LYyEXdMPspMYbaDszwAhyLmxjnZRin4VT2MQAAgAAAAIAAAACAAAAAAAkAAAAAAQEfAOH1BQAAAAAWABQ0cdziSHYB3uLWPGRWo5fppqBKwiIGAr2/OvdLL08VWlUSm9OwHIX/MMIe0vuCF4fQxTAqCxlFGKfhVPYxAACAAAAAgAAAAIAAAAAAKgAAAAABAR8A4fUFAAAAABYAFA4J9EIp3Q0529taEyNUE063IFqNIgYCmwY0q/kIGfSYaH77lVTyv2/Ui2lbOKGpeMCz0pRsEFcYp+FU9jEAAIAAAACAAAAAgAAAAAAjAAAAAAEBHwDh9QUAAAAAFgAUhtitDvvm0IKqZbl4UUgckQL6Xs0iBgIko7Q3UoVnHGy+2KtNBC8Pm5zjd6qZNtE+6d/zoEz9cxin4VT2MQAAgAAAAIAAAACAAAAAACwAAAAAAQEfAOH1BQAAAAAWABSuTGCQT6UMxySNacCDerDdLGhB+CIGAqTvTKUkuheMJ9qebkIngarunKgqwdRxjnDNJbEYjkMzGKfhVPYxAACAAAAAgAAAAIAAAAAADwAAAAABAR8A4fUFAAAAABYAFMDo3cWQvrtLE9fNx/iIHfrVWSRcIgYCkAUz1xOXMu8OlXWYfuAUmayfxxzQU5hDgBwD0MI87yEYp+FU9jEAAIAAAACAAAAAgAAAAAASAAAAAAEBHwDh9QUAAAAAFgAUhh0upp0Lk3mS2B3+IuRBZJjsMGAiBgK0etS/dTcHZ/hNIlag2Z76m3MtPkBPpbAbn0IDRMsBJBin4VT2MQAAgAAAAIAAAACAAAAAAAoAAAAAAQEfAOH1BQAAAAAWABS2KVhBbV/0S4pViMenJ7U8TpUGzyIGA5fmmxiU8FnAc7s03lF23d2Bv1S53Lp3gLbDIXGm953kGKfhVPYxAACAAAAAgAAAAIAAAAAABgAAAAABAR8A4fUFAAAAABYAFIEJggLiwyjPK7Ya8qHJoYnFcFbpIgYDSYr927ncOpJ/QoiMLgCrAHqdtNuqPbqslRmS96FW3asYp+FU9jEAAIAAAACAAAAAgAAAAAALAAAAAAEBHwDh9QUAAAAAFgAUgbKPfiIdKVhayqKkMYZHwkaxj3MiBgOpJ9Si/U6okqqPDR5gqovKzSYrzLG7NulLtPAJb8B6Pxin4VT2MQAAgAAAAIAAAACAAAAAAAEAAAAAAQEfAOH1BQAAAAAWABQuicKxEipauMaKHSsqrwLPAj1pqiIGA2neAr2zKUjgscJjL0n0b71aVjyGBDIhVNJ7zaDWaLRCGKfhVPYxAACAAAAAgAAAAIAAAAAAMgAAAAABAR8A4fUFAAAAABYAFPcgerlGE9mlFt3yZBoj3y9dnX/wIgYCweWGZxq4q7upZ7/iWz9B2DeJcj2fWZb8cquhgZMp9wUYp+FU9jEAAIAAAACAAAAAgAAAAAAiAAAAAAEBHwDh9QUAAAAAFgAUQ/NqRUpa520jmJR2nonc7JWWKtgiBgNqe49thPcK+Y6Ntl0ylkVWnVYgfYoiQ7N+f8nl5v1c7Bin4VT2MQAAgAAAAIAAAACAAAAAADUAAAAAAQEfAOH1BQAAAAAWABRkGHIkVFpZTCC01a7VvO1KjKTTqyIGAr/BOyz5Vx26JFVv/NRKp9MHz19DOHMRWe53KwBVzvK0GKfhVPYxAACAAAAAgAAAAIAAAAAADQAAAAAAIgIDIWjVNyVyqUT3Ar/jbK6TP3NWtQCzrlUMXBCnvPFCIx4Yp+FU9jEAAIAAAACAAAAAgAAAAAA2AAAAAA==

I can see 9949 out of 9992 chars in the textbox if I CTRL+A , CTRL+C it seems I copy the whole transaction (9992 chars). If I click "broadcast transaction" it says "Invalid Hex String".

@NicolasDorier the text being cutoff visually in the TextBox is a known issue (same bug that plagues the Privacy, License, T&C textboxes). I'm not familiar with Transaction Hex's yet but i'll check why it fails.

I checked the string that is passed to PSBT and it seems that the MultiTextBox control doesn't do anything suspicious on the string.

@NicolasDorier so i debugged it further and the exceptions are coming from these lines:
https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Gui/Controls/WalletExplorer/TransactionBroadcasterViewModel.cs#L174
Exception comes from NBitcoin, stacktrace:

Exception thrown: 'NBitcoin.PSBTException' in NBitcoin.dll: 'Input 0: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 1: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 2: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 3: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 4: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 5: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 6: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 7: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 8: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 9: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 10: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 11: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 12: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 13: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 14: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 15: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 16: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 17: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 18: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 19: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 20: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 21: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 22: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 23: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 24: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 25: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 26: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 27: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 28: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 29: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 30: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 31: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 32: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 33: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 34: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 35: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 36: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 37: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 38: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 39: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 40: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 41: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 42: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 43: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 44: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 45: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 46: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 47: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 48: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 49: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 50: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 51: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 52: The finalized input script does not properly validate "WitnessProgramMissmatch"
Input 53: The finalized input script does not properly validate "WitnessProgramMissmatch"'
   at NBitcoin.PSBT.Finalize()
   at WalletWasabi.Gui.Controls.WalletExplorer.TransactionBroadcasterViewModel.<OnDoTransactionBroadcastAsync>d__36.MoveNext() in /(redacted)/WalletWasabi/WalletWasabi.Gui/Controls/WalletExplorer/TransactionBroadcasterViewModel.cs:line 174

then running it further gets me to this line + exception dump:
https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Gui/Controls/WalletExplorer/TransactionBroadcasterViewModel.cs#L181


Exception thrown: 'System.FormatException' in NBitcoin.dll: 'Invalid Hex String'
   at NBitcoin.DataEncoders.HexEncoder.DecodeData(String encoded)
   at NBitcoin.Transaction.Parse(String hex, Nullable`1 version, Network network)
   at NBitcoin.Transaction.Parse(String hex, Network network)
   at WalletWasabi.Gui.Controls.WalletExplorer.TransactionBroadcasterViewModel.<OnDoTransactionBroadcastAsync>d__36.MoveNext() in /(redacted)/WalletWasabi/WalletWasabi.Gui/Controls/WalletExplorer/TransactionBroadcasterViewModel.cs:line 181

thanks @jmacato . Wasabi try to extract the transaction from PSBT, fails, then fallback trying to parse the base64 as a transaction, fail and show this message..

I think the error message must be fixed, because my string is correct, the PSBT CAN be parsed, but not finalized. The wrong error message + the visual cutoff made me take the wrong assumptions.

A better error message would be "The PSBT can't be finalized"

@NicolasDorier yes i think that exception should be displayed correctly. But im not sure what was the rationale with not catching specific Exception messages.

@jmacato I don't think there was rational. Probably @nopara73 did not know that Finalize could throw exception and thus considered that anything throwing exception mean the PSBT is not valid (which is partially true, it is a valid PSBT, but can't be finalized) and thus it should be a Transaction in hex instead. (which is wrong)

If i parse it correctly, then perhaps it'll be enough if we catch PSBTException then say that the PSBT was not finalized? If it's other exception then perhaps try doing Transaction Hex? Would that work?

@jmacato yes this would work..

@NicolasDorier Awesome, will fire up a PR right now :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nopara73 picture nopara73  路  3Comments

kenny47 picture kenny47  路  3Comments

yahiheb picture yahiheb  路  3Comments

MaxHillebrand picture MaxHillebrand  路  3Comments

MaxHillebrand picture MaxHillebrand  路  3Comments