Walletwasabi: Warning message on CoinJoin tab does not wrap

[benthecarman]

Minor thing as well, LurkingWifeMode does not hide the coin's Id

[nopara73]

This'll be removed from here (and most warning messages) after the new Avalonia release is out we'll have Toast Notifications.

[jmacato]

This is a symptom of #1106 i think.

[lontivero]

@jmacato @benthecarman I agree that in general text shouldn't be cut and wrapping is a solution to have in mind. However in this particular case the problem is not how we display the message but the message itself.

In those cases where the error is unexpected, for the sake of the example let say System.IOException A connection attempt failed because ...., we should display something like "There was an unexpected error please try again" (or something like that) However, when the error is in some way expected we shouldn't display System.NotSupportedException: ....ConnectionConfirmation....9f83ae3... we should display something friendlier like "Coin cannot be dequeued during the confirmation phase" or something like that.

[jmacato]

@lontivero I agree, we need to have friendlier exception messages. We can also try to avoid them (at least on our own code) by using ErrorDescriptors instead of throwing exceptions and costing us stackframes/perf.

[lontivero]

@jmacato you and @danwalmsley are the experts so, you have to decide the best way to implement this improvement. What is important to me as a user is that this kind of error messages suck too bad.

[nopara73]

Please hold on with this issue until the notifications are done. Working on it now would not be the most efficient. We are running a marathon, not a sprint.

[jmacato]

@lontivero we probably should make good use of ErrorDescriptors on the code that generates these errors instead of throwing exceptions. Then perhaps handle those with either notifications or whichever we can come up with as we go along.

[nopara73]

https://github.com/zkSNACKs/WalletWasabi/pull/2544