Walletwasabi: ExtendedTextBox popup menu clears selection

[molnard]

General Description

When text is selected in a TextBox and the user tries to right click on the selected text the Copy/Paste context menu shown but the selection is gone. In that way the user cannot copy the selected text.
Another problem is even if you manage to keep the selection with the right click the end of the selection is modified. Right click should not adjust the selection.

How To Reproduce?

1. Go to Send Tab.
2. Write something to Label TextBox.
3. Select part of the entered text.
4. Right click on the selection.
5. Selection is lost.

Operating System

Win10x64

Wasabi Version

In every version.

[molnard]

Tried this solution with the Focusable = false, unfortunately it was not working.

Another hacky solution is to:
C# protected override void OnLostFocus(RoutedEventArgs e) { e.Handled = true; }
In that way a logic has to be added when to lost the focus.

[lontivero]

I would like to propose a radical change here: remove the selection and the context menu for copy. This is my reasoning: Given that doesn't make any sense to select just a part of an address nor part of a transaction id neither, forcing users to select the text, do right click and click on the only available option (copy) is not good UX.

I think it would be great to have a small button on the right side ot the ExtendedTextBox that when clicked copy the content to the clipboard. I am thinking on a button similar to the one @molnard added to the NoparaPasswordBox to see the typed password.

[nopara73]

Yes, that's what we decided, too, we removed it for now. Regardless it should work, because this thing affects every textbox, not only the one mentioned.

[nopara73]

Oh wait, David is talking about the Send tab's Label box. We removed if from another place. The same comment still applies: regardless this should work.

Regarding coppy button: We cannot afford any more friction and complexity to the UI at this point: https://github.com/zkSNACKs/WalletWasabi/issues/1369

[lontivero]

Regarding coppy button: We cannot afford any more friction and complexity to the UI at this point

That's why we should remove all the selection, caret moving, mouse event handling and that kind of complex things.

[danwalmsley]

https://github.com/AvaloniaUI/Avalonia/issues/2692

[danwalmsley]

fixed!