Vscode-pull-request-github: [Feature request] VSCodium support

[Toub]

Installing this extension on vscodium 1.37.1.

Then, click on "Configure" icon on the new Github tab.

The following error occurs:

Notification message:

command 'pr.configurePRViewlet' not found

Output view:

[Info] Looking for git repository

Developer console

[Extension Host] debugger listening on port 16659

workbench.main.js:sourcemap:3351 Extension 'GitHub.vscode-pull-request-github cannot use PROPOSED API (must started out of dev or enabled via --enable-proposed-api)
updateEnableProposedApi @ workbench.main.js:sourcemap:3351

Activating extension 'GitHub.vscode-pull-request-github' failed: [GitHub.vscode-pull-request-github]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api GitHub.vscode-pull-request-github.
_logMessageInConsole @ workbench.main.js:sourcemap:3348
workbench.main.js:sourcemap:242 [Extension Host] Activating extension GitHub.vscode-pull-request-github failed: [GitHub.vscode-pull-request-github]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api GitHub.vscode-pull-request-github

[Extension Host] Here is the error stack: Error: [GitHub.vscode-pull-request-github]:
Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api GitHub.vscode-pull-request-github
at c (/usr/share/codium/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:489:844)
at new t.PullRequestsTreeDataProvider (/home/toub/.vscode-oss/extensions/github.vscode-pull-request-github-0.10.0/media/extension.js:1:399642)
at /home/toub/.vscode-oss/extensions/github.vscode-pull-request-github-0.10.0/media/extension.js:1:632294
at Generator.next ()
at n (/home/toub/.vscode-oss/extensions/github.vscode-pull-request-github-0.10.0/media/extension.js:1:630635)
at new Promise ()
at n (/home/toub/.vscode-oss/extensions/github.vscode-pull-request-github-0.10.0/media/extension.js:1:630412)
at t.activate (/home/toub/.vscode-oss/extensions/github.vscode-pull-request-github-0.10.0/media/extension.js:1:631897)
at Function._callActivateOptional (/usr/share/codium/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:764:518)
at Function._callActivate (/usr/share/codium/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:764:207)
at define._doActivateExtension.Promise.all.then.e (/usr/share/codium/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:763:245)

notificationsAlerts.ts:38 Error: command 'pr.configurePRViewlet' not found

Is this extension supposed to work on vscodium, and is there a chance it is supported in the future?

[RMacfarlane]

Hey @Toub, yes, the extension should work on vscodium, but you do have to provide an additional flag when launching. Using code --enable-proposed-api GitHub.vscode-pull-request-github from the command line should work.

The reason for this is that in the product build of VSCode, the product.json gets updated to whitelist some extensions as being allowed to use the proposed API, and this isn't in the build of VSCodium. Once all parts of the API we're using are no longer proposed, it will work without the flag.

[RMacfarlane]

I created an issue to track removing the command line switch: https://github.com/microsoft/vscode-pull-request-github/issues/1310

[Toub]

Ok great. Thanks for the clarification!

[RMacfarlane]

Closing this since you're unblocked and there's another issue to track the removal of the command line switch. Thanks!

[scottwallacesh]

Hey @Toub, yes, the extension should work on vscodium, but you do have to provide an additional flag when launching. Using code --enable-proposed-api GitHub.vscode-pull-request-github from the command line should work.

To prevent you running from the command line each time, you can add an entry to ~/.vscode-oss/argv.json:

{
    // Allow Github Pull Request to work
    "enable-proposed-api": [
        "GitHub.vscode-pull-request-github"
    ]
}

[JamesS-M]

Hey @Toub, yes, the extension should work on vscodium, but you do have to provide an additional flag when launching. Using code --enable-proposed-api GitHub.vscode-pull-request-github from the command line should work.

To prevent you running from the command line each time, you can add an entry to ~/.vscode-oss/argv.json:

{
    // Allow Github Pull Request to work
    "enable-proposed-api": [
        "GitHub.vscode-pull-request-github"
    ]
}

@scottwallacesh Thank you so much for this!