Vscode-pull-request-github: Show changes since last review

Created on 4 Sep 2018  路  4Comments  路  Source: microsoft/vscode-pull-request-github

GitHub.com flow

Blue line indicates there's a change:

image

Blue + indicates where I need to look from, handy link to the diff since I last looked:

image

Extension

No indication in tree (ie. I need to check notifications/email/github.com before switching back to extension):

image

No indication which commits/comments are new:

image

feature-request

Most helpful comment

I can use this extension the first time I look at a PR, but after there are changes I can't. I don't need to re-review everything. I just need to review the changes since the last time I looked. Just being able to select which commits to use would solve this for me.

All 4 comments

It might be even more useful to be able to select the commits to review (because "changes since last review" sometimes does not work as expected + gets cleared once you open the changes on github).

I can use this extension the first time I look at a PR, but after there are changes I can't. I don't need to re-review everything. I just need to review the changes since the last time I looked. Just being able to select which commits to use would solve this for me.

To add on

because "changes since last review" sometimes does not work as expected
I don't need to re-review everything. I just need to review the changes since the last time I looked.

and now that there is the Viewed checkbox, I'd like to revisit the ask:

The files that Changed since last view should not show the full PR diff but only the diff since last Viewed of each changed file.
Right now one has no other choice than to review the changed file completely all over.

This behavior could be toggled by clicking Changed since last view.

Any update on this? This extension is really amazing but I think this is one of the key features that it's missing.

Was this page helpful?
0 / 5 - 0 ratings