Vscode-pull-request-github: Hitting "API rate limit exceeded" for most PR listing operations

[IgorMinar]

• Extension version: 0.2.3
• VSCode Version: 1.29.1
• OS: Mac OS 10.14.1

Steps to Reproduce:

1. checkout angular/angular
2. try to expand any of the PR categories under Source Control / Github Pull Requests (Assigned To Me, Awaiting For My Review, Created By Me)

What I get is:

And the listing expands with 0 pull requests:

Surprisingly, if I try to expand the All category, the list does expand:

[RMacfarlane]

@IgorMinar Can you run git remote -v to see how many remotes you have? For these categories, we search the issues of each remote until we have a page size of results, so I'm wondering if that's the problem

[IgorMinar]

@RMacfarlane I have 68 remotes (I have lots of friends I work with 😄 )

and it does seem to be the issue because when I test the extension in another local fork of the repo with just a handful of remotes I don't see the errors.

Why do you search the remotes? I'd expect you go to github via the api and get the listing of PRs assigned to me from there.

[RMacfarlane]

Thanks for the info!

To clarify, we're not searching remotes, we're searching the issues in remotes. We are using the github api for search, since the api for listing PRs doesn't support querying by user

[IgorMinar]

@RMacfarlane is this because you don't know what is the upstream/main repo with the issues?

could you rely on conventions like "origin" and "upstream" and search just those? And if users want other remotes to be search they'd have to explicitly configure the extension to do so.

[IgorMinar]

oh no. I've just hit the rate limit even on my clone with few remotes because the extension refreshes any of the expanded lists every time I switch branches, pull from remote and update my current branch, or even simply rebase or make a commit.

[RMacfarlane]

@IgorMinar Yeah, I have a PR open with the mitigation you suggest, searching for "upstream" and "origin" remotes and using those first. I think having clearer UI about what remote is being used and a setting to configure it would be good to add.

[RMacfarlane]

Closing since this should be fixed in the latest version of the extension, we do only search for "upstream" and "origin" remotes by default now