Vscode-pull-request-github: Update docs for Github Enterprise support

[auchenberg]

Update docs for Github Enterprise support.

• steps to enable
• required GH Enterprise version,
• links to existing docs

[shana]

The versions of GHE that support sign in are:

• 2.14.5 and above
• 2.13.11 and higher 2.13.x
• 2.12.19 and higher 2.12.x
• 2.11.25

Other versions will need a personal access token configured with the scopes read:user, repo, user:email, write:discussion. Looks like there are a few enterprise versions that don't have the write:discussion scope available, so I think I'll need to do something about that (the scope is not absolutely essential so it's not a hard requirement).

[ryanspletzer]

Is there a way on Windows to pre-set a personal access token in the Windows Credential Manager for GitHub Enterprise? (We're running one of the versions that doesn't support sign-in, so I have to set a PAT manually.)

I've tried setting this in Windows Credential Manager, mimicking the one that I saw from public GitHub:

and I have this in settings:

I've also tried setting the 'username' in settings to my internal Active Directory LDAP sAMAccountName (which is what my company uses for auth to GitHub Enterprise at this time), but that made no difference, in any case I get this error when trying to bring up PR's:

Oh btw we're on 12.13.4 hence why sign-in doesn't work.

[shana]

@ryanspletzer I've opened issue #512 to track your problem with some questions.

[cederfjard]

The versions of GHE that support sign in are:

• 2.14.5 and above
• 2.13.11 and higher 2.13.x
• 2.12.19 and higher 2.12.x
• 2.11.25

Other versions will need a personal access token configured with the scopes read:user, repo, user:email, write:discussion. Looks like there are a few enterprise versions that don't have the write:discussion scope available, so I think I'll need to do something about that (the scope is not absolutely essential so it's not a hard requirement).

So just to clarify: We're on version 2.12.13, and there's no write:discussion scope when I generate access tokens. This is probably the reason that I can't sign in, then? (Also see here: https://github.com/Microsoft/vscode-pull-request-github/issues/382#issuecomment-420639536)

[shana]

@cederfjard The latest release (0.1.6) has a fix for the problematic scopes, so you should be able to login to GHE 2.12.13 with a personal access token now.

[maurofranchi]

What permission do we need to grant to the token for GitEnterprise v2.13.4?

[shana]

@maurofranchi read:user, repo and user:email

[maurofranchi]

@shana thanks it worked!!

[shana]

The docs have been updated with all the information gathered here, https://github.com/Microsoft/vscode-pull-request-github/wiki#2-is-github-enterprise-supported

[auchenberg]

🎉