Vscode-pull-request-github: Add support for multi-root workspaces

Created on 10 Sep 2018  路  5Comments  路  Source: microsoft/vscode-pull-request-github

Multi-root folder support: Investigate how the active source control provider can control what's visible in the PR viewlets

feature-request

Most helpful comment

Basic support for this was added in version 0.2.0 of the extension. Changing the selected repository should update the panel and all other PR related UI

folder_select

Multiselecting isn't supported yet

All 5 comments

Wanted to know if what I experience is actually related to this (missing) enhancement.

VSCode 1.27.1
GitHub Pull Requests 0.1.2

1) I have an empty Workspace
2) I added a folder with a github repo ("repo1")
3) SCM tree view shows "Github Pull Requests" and I can see the PRs for "repo1"
4) I added a second folder with another github repo ("repo2") to the Workspace
5) SCM tree views only shows PRs from "repo1", nothing about "repo2"

Is that the expected result given current implementation?

My understanding of "multi-root folders" is somewhat different, and was actually expecting the above scenario to work, but perhaps I'm wrong and if so - sorry for the noise! and looking forward for this to be implemented 馃槃

@dannyk81 Yup, that is the expected result currently. A new "Selected source controls" API was recently added to VSCode (https://code.visualstudio.com/updates/v1_27#_scm-selected-source-controls) that we're planning to use to update the SCM tree view

Basic support for this was added in version 0.2.0 of the extension. Changing the selected repository should update the panel and all other PR related UI

folder_select

Multiselecting isn't supported yet

Awesome! -- Can't wait for multi-select support

Thanks to @RMacfarlane and @joaomoreno we already shipped this feature in 0.2.3.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Jonnokc picture Jonnokc  路  3Comments

kieferrm picture kieferrm  路  4Comments

jrieken picture jrieken  路  3Comments

RamonMeffert picture RamonMeffert  路  3Comments

alexdima picture alexdima  路  3Comments