Vscode-pull-request-github: Ridiculously large vsix size
At 141MB, this extension is ridiculously large. Is it please possible to trim some of the fat?
alexdima
All 3 comments
OMG I just came here for this. Extracted, the extension totals 301MB, of which 280MB is the dugite dependency which ships an ENTIRE git installation with it.
We already have a great, Promise-based, git api in our Git extension, which is an issue away from getting its full API exported to other extensions. It leverages the user's Git installation. Created #19
Can we maybe do that instead?
joaomoreno
on 26 Jun 2018
I used Dugite like a no-brainer as I don't want to go deep into git. Now I removed the Dugite dependency and use the local git provided by the vscode.git extension and spawn commands directly. Tested on macOS, Linux and two Windows machines, it works fine but I'm pretty sure that it can fail if one has a special git setup.
Here is the new bits without Dugite https://github.com/Microsoft/vscode-pull-request-github/releases/tag/v0.0.2 , it's 8MB zipped and 25~30MB unzipped. There are chances of reducing the size, like tree-shake moment.js.
@joaomoreno thanks, it makes things easier especially authentication.
rebornix
on 27 Jun 2018
Thanks! This is much much better!!
alexdima
on 27 Jun 2018
Related issues
kieferrm
路
4Comments
dbaeumer
路
4Comments
erihanse
路
4Comments
radu-matei
路
3Comments
Simran-B
路
4Comments
Most helpful comment
I used Dugite like a no-brainer as I don't want to go deep into
git. Now I removed the Dugite dependency and use the local git provided by thevscode.gitextension and spawn commands directly. Tested on macOS, Linux and two Windows machines, it works fine but I'm pretty sure that it can fail if one has a special git setup.Here is the new bits without Dugite https://github.com/Microsoft/vscode-pull-request-github/releases/tag/v0.0.2 , it's 8MB zipped and 25~30MB unzipped. There are chances of reducing the size, like tree-shake moment.js.
@joaomoreno thanks, it makes things easier especially authentication.